From: Eric Paris <eparis@redhat.com>
To: Anders Blomdell <anders.blomdell@control.lth.se>
Cc: Eric Paris <eparis@parisplace.org>, linux-kernel@vger.kernel.org
Subject: Re: fanotify issues in 2.6.34-rc6-next-20100506
Date: Fri, 07 May 2010 12:57:01 -0400 [thread overview]
Message-ID: <1273251421.15368.208.camel@localhost> (raw)
In-Reply-To: <4BE3DC60.7080105@control.lth.se>
On Fri, 2010-05-07 at 11:24 +0200, Anders Blomdell wrote:
> seems to lose/corrupt events. For instance running 'fanotify -c /dir/to/watch'
> and then running the command 'cd /dir/to/watch ; touch a b c d e f g h i j k l'
> might generate (results are more or less random):
sometimes I'm not the sharpest knife in the drawer. switch statements
are hard.
diff --git a/fs/notify/fanotify/fanotify.c b/fs/notify/fanotify/fanotify.c
index bbcfccd..34c9661 100644
--- a/fs/notify/fanotify/fanotify.c
+++ b/fs/notify/fanotify/fanotify.c
@@ -21,6 +21,7 @@ static bool should_merge(struct fsnotify_event *old, struct fsnotify_event *new)
if ((old->path.mnt == new->path.mnt) &&
(old->path.dentry == new->path.dentry))
return true;
+ break;
case (FSNOTIFY_EVENT_NONE):
return true;
default:
next prev parent reply other threads:[~2010-05-07 16:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-07 9:24 fanotify issues in 2.6.34-rc6-next-20100506 Anders Blomdell
2010-05-07 13:21 ` Eric Paris
2010-05-07 16:57 ` Eric Paris [this message]
2012-06-04 1:49 ` JohnG
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1273251421.15368.208.camel@localhost \
--to=eparis@redhat.com \
--cc=anders.blomdell@control.lth.se \
--cc=eparis@parisplace.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.