All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alex Deucher <alexdeucher@gmail.com>
To: airlied@gmail.com, dri-devel@lists.freedesktop.org
Cc: mjg59@srcf.ucam.org
Subject: [PATCH 3/9] drm/radeon/kms: re-enable gui idle interrupts on r6xx+
Date: Fri,  7 May 2010 17:16:14 -0400	[thread overview]
Message-ID: <1273266980-20982-4-git-send-email-alexdeucher@gmail.com> (raw)
In-Reply-To: <1273266980-20982-3-git-send-email-alexdeucher@gmail.com>

Signed-off-by: Alex Deucher <alexdeucher@gmail.com>
---
 drivers/gpu/drm/radeon/radeon_pm.c |   24 +++++++++++++-----------
 1 files changed, 13 insertions(+), 11 deletions(-)

diff --git a/drivers/gpu/drm/radeon/radeon_pm.c b/drivers/gpu/drm/radeon/radeon_pm.c
index 2eb675e..bded834 100644
--- a/drivers/gpu/drm/radeon/radeon_pm.c
+++ b/drivers/gpu/drm/radeon/radeon_pm.c
@@ -64,17 +64,19 @@ static void radeon_pm_set_clocks(struct radeon_device *rdev, int static_switch)
 	mutex_lock(&rdev->ddev->struct_mutex);
 	mutex_lock(&rdev->vram_mutex);
 	mutex_lock(&rdev->cp.mutex);
-#if 0
-	/* wait for GPU idle */
-	rdev->pm.gui_idle = false;
-	rdev->irq.gui_idle = true;
-	radeon_irq_set(rdev);
-	wait_event_interruptible_timeout(
-		rdev->irq.idle_queue, rdev->pm.gui_idle,
-		msecs_to_jiffies(RADEON_WAIT_IDLE_TIMEOUT));
-	rdev->irq.gui_idle = false;
-	radeon_irq_set(rdev);
-#endif
+
+	/* gui idle int has issues on older chips it seems */
+	if (rdev->family >= CHIP_R600) {
+		/* wait for GPU idle */
+		rdev->pm.gui_idle = false;
+		rdev->irq.gui_idle = true;
+		radeon_irq_set(rdev);
+		wait_event_interruptible_timeout(
+			rdev->irq.idle_queue, rdev->pm.gui_idle,
+			msecs_to_jiffies(RADEON_WAIT_IDLE_TIMEOUT));
+		rdev->irq.gui_idle = false;
+		radeon_irq_set(rdev);
+	}
 	radeon_unmap_vram_bos(rdev);
 
 	if (!static_switch) {
-- 
1.5.6.3

  reply	other threads:[~2010-05-07 21:17 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-07 21:16 [PATCH 0/9] drm/radeon/kms: update pm code Alex Deucher
2010-05-07 21:16 ` [PATCH 1/9] drm/radeon/kms: enable misc pm power state features on r5xx, rs6xx Alex Deucher
2010-05-07 21:16   ` [PATCH 2/9] drm/radeon/kms: enable misc pm power state features on r1xx-r4xx Alex Deucher
2010-05-07 21:16     ` Alex Deucher [this message]
2010-05-07 21:16       ` [PATCH 4/9] radeon: Split out ring locking and allocation Alex Deucher
2010-05-07 21:16         ` [PATCH 5/9] radeon: Use fences to gate entry to reclocking on <r600 Alex Deucher
2010-05-07 21:16           ` [PATCH 6/9] drm/radeon/kms: fix lock ordering in ring, ib handling Alex Deucher
2010-05-07 21:16             ` [PATCH 7/9] drm/radeon/kms/pm: add support for no display power states Alex Deucher
2010-05-07 21:16               ` [PATCH 8/9] drm/radeon/kms/pm: rework power management Alex Deucher
2010-05-07 21:16                 ` [PATCH 9/9] drm/radeon/kms/pm: make pm spam debug only Alex Deucher
2010-05-07 21:23 ` [PATCH 0/9] drm/radeon/kms: update pm code Matthew Garrett
2010-05-07 22:24   ` Alex Deucher
2010-05-08 11:14 ` Klaus Doblmann B.A.
2010-05-08 15:29   ` Alex Deucher
2010-05-08 18:46     ` Klaus Doblmann B.A.
2010-05-10 16:04 ` Andy Furniss
2010-05-10 16:47   ` Alex Deucher
2010-05-10 17:25     ` Andy Furniss
2010-05-10 17:28       ` Rafał Miłecki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1273266980-20982-4-git-send-email-alexdeucher@gmail.com \
    --to=alexdeucher@gmail.com \
    --cc=airlied@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=mjg59@srcf.ucam.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.