From: Christoph Fritz <chf.fritz@googlemail.com>
To: "Peter M. Petrakis" <peter.petrakis@canonical.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org, rubini <rubini@cvml.unipv.it>,
Christopher Heiny <cheiny@synaptics.com>
Subject: Re: [PATCH] Reset ps/2 port should psmouse_probe fail before retrying
Date: Sat, 08 May 2010 18:01:27 +0200 [thread overview]
Message-ID: <1273334487.7427.3.camel@lovely> (raw)
In-Reply-To: <4BE45474.8040001@canonical.com>
On Fri, 2010-05-07 at 13:57 -0400, Peter M. Petrakis wrote:
> So where do we stand on this? Option #2 sounds like a good
> thing to implement regardless of whether synaptics is the
> victim device or not. Devices supported by the fall back driver
> will eventually get our attention again when users wish to use
> the extended features of the device. In the meanwhile, at least
> they'll have a reliable, minimum set of features.
>
> I'm happy to continue instrumenting this mysterious synaptics
> device. Just keep the patches coming. Thanks.
You can wipe out this (maybe for firmware >7.5 obsolete) 0x47 check in
synaptics_capability() and see if it works with synaptics driver.
diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
index 026df60..6750dbb 100644
--- a/drivers/input/mouse/synaptics.c
+++ b/drivers/input/mouse/synaptics.c
@@ -138,7 +138,9 @@ static int synaptics_capability(struct psmouse *psmouse)
return -1;
priv->capabilities = (cap[0] << 16) | (cap[1] << 8) | cap[2];
priv->ext_cap = 0;
- if (!SYN_CAP_VALID(priv->capabilities))
+ if (!SYN_CAP_VALID(priv->capabilities) &&
+ SYN_ID_MAJOR(priv->identity) < 7 &&
+ SYN_ID_MINOR(priv->identity) < 5)
return -1;
/*
next prev parent reply other threads:[~2010-05-08 15:55 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-16 22:52 [PATCH] Reset ps/2 port should psmouse_probe fail before retrying Peter M. Petrakis
2010-04-17 11:01 ` Christoph Fritz
2010-04-17 15:31 ` Peter M. Petrakis
2010-04-17 16:53 ` Christoph Fritz
2010-04-19 15:33 ` Peter M. Petrakis
2010-04-20 0:37 ` Christoph Fritz
2010-04-20 21:08 ` Peter M. Petrakis
2010-04-21 6:33 ` Dmitry Torokhov
2010-04-21 16:05 ` Peter M. Petrakis
2010-04-21 17:10 ` Dmitry Torokhov
2010-04-21 19:38 ` Peter M. Petrakis
2010-04-21 19:52 ` Dmitry Torokhov
2010-04-21 21:10 ` Peter M. Petrakis
2010-04-22 16:28 ` Christoph Fritz
2010-04-22 21:48 ` Peter M. Petrakis
2010-04-22 21:55 ` Dmitry Torokhov
2010-04-23 0:47 ` Christoph Fritz
2010-04-23 16:53 ` Dmitry Torokhov
2010-04-23 18:46 ` Peter M. Petrakis
2010-04-28 17:07 ` Dmitry Torokhov
2010-04-28 20:17 ` Peter M. Petrakis
2010-04-29 16:57 ` Christoph Fritz
2010-04-29 17:46 ` Dmitry Torokhov
2010-04-30 22:37 ` Peter M. Petrakis
2010-05-02 3:07 ` Christoph Fritz
2010-05-02 7:41 ` Christoph Fritz
2010-05-07 17:57 ` Peter M. Petrakis
2010-05-08 16:01 ` Christoph Fritz [this message]
2010-04-24 1:22 ` Christoph Fritz
2010-04-24 10:00 ` Christoph Fritz
2010-04-28 7:26 ` Dmitry Torokhov
2010-05-08 16:22 ` Christoph Fritz
2010-05-11 8:22 ` Dmitry Torokhov
2010-05-11 22:24 ` Christoph Fritz
-- strict thread matches above, loose matches on Subject: below --
2010-04-14 20:46 Peter M. Petrakis
2010-04-14 21:04 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1273334487.7427.3.camel@lovely \
--to=chf.fritz@googlemail.com \
--cc=cheiny@synaptics.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=peter.petrakis@canonical.com \
--cc=rubini@cvml.unipv.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.