From: Peter Zijlstra <peterz@infradead.org>
To: Lin Ming <ming.m.lin@intel.com>
Cc: Ingo Molnar <mingo@elte.hu>,
Frederic Weisbecker <fweisbec@gmail.com>,
"eranian@gmail.com" <eranian@gmail.com>,
"Gary.Mohr@Bull.com" <Gary.Mohr@bull.com>,
Corey Ashford <cjashfor@linux.vnet.ibm.com>,
"arjan@linux.intel.com" <arjan@linux.intel.com>,
"Zhang, Yanmin" <yanmin_zhang@linux.intel.com>,
Paul Mackerras <paulus@samba.org>,
"David S. Miller" <davem@davemloft.net>,
Russell King <rmk+kernel@arm.linux.org.uk>,
Paul Mundt <lethal@linux-sh.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [RFC][PATCH 2/9] perf: core, remove hw_perf_event_init
Date: Mon, 10 May 2010 11:42:21 +0200 [thread overview]
Message-ID: <1273484541.5605.3336.camel@twins> (raw)
In-Reply-To: <1273483595.15998.56.camel@minggr.sh.intel.com>
On Mon, 2010-05-10 at 17:26 +0800, Lin Ming wrote:
> A new field "pmu_id" is added to struct perf_event_attr.
>
> 2 new functions: perf_event_register_pmu, perf_event_lookup_pmu
> perf_event_register_pmu: the pmu registration facility
> perf_event_lookup_pmu: lookup the pmu via the passed in event->attr.pmu_id.
>
> A new api pmu->init_event to replace hw_perf_event_init
Another problem, this patch breaks all of perf by removing the weak call
before there is a replacement.
Please rework such that there is a smooth transition.
Also, for compatibilities sake, the cpu pmu will be required to get
pmu_id==0, this doesn't provide that.
next prev parent reply other threads:[~2010-05-10 9:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-10 9:26 [RFC][PATCH 2/9] perf: core, remove hw_perf_event_init Lin Ming
2010-05-10 9:40 ` Peter Zijlstra
2010-05-10 10:17 ` Lin Ming
2010-05-10 10:19 ` Peter Zijlstra
2010-05-10 10:22 ` Lin Ming
2010-05-10 12:27 ` Frederic Weisbecker
2010-05-10 12:54 ` Peter Zijlstra
2010-05-10 23:09 ` Frederic Weisbecker
2010-05-11 6:38 ` Peter Zijlstra
2010-05-11 6:44 ` Lin Ming
2010-05-11 6:51 ` Ingo Molnar
2010-05-11 7:00 ` Lin Ming
2010-05-11 9:18 ` Peter Zijlstra
2010-05-11 6:50 ` Frederic Weisbecker
2010-05-10 9:42 ` Peter Zijlstra [this message]
2010-05-10 10:15 ` Lin Ming
2010-05-10 12:24 ` Frederic Weisbecker
2010-05-12 2:11 ` Lin Ming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1273484541.5605.3336.camel@twins \
--to=peterz@infradead.org \
--cc=Gary.Mohr@bull.com \
--cc=arjan@linux.intel.com \
--cc=cjashfor@linux.vnet.ibm.com \
--cc=davem@davemloft.net \
--cc=eranian@gmail.com \
--cc=fweisbec@gmail.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.m.lin@intel.com \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=yanmin_zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.