From: Michael Ellerman <michael@ellerman.id.au>
To: Anton Blanchard <anton@samba.org>
Cc: mikey@neuling.org, paulus@samba.org, miltonm@bga.com,
linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 2/3] powerpc: kdump: CPUs assume the context of the oopsing CPU
Date: Tue, 11 May 2010 14:14:31 +1000 [thread overview]
Message-ID: <1273551271.9209.135.camel@concordia> (raw)
In-Reply-To: <20100511022551.GF12203@kryten>
[-- Attachment #1: Type: text/plain, Size: 771 bytes --]
On Tue, 2010-05-11 at 12:25 +1000, Anton Blanchard wrote:
> We wrap the crash_shutdown_handles[] calls with longjmp/setjmp, so if any
> of them fault we can recover. The problem is we add a hook to the debugger
> fault handler hook which calls longjmp unconditionally.
>
> This first part of kdump is run before we marshall the other CPUs, so there
> is a very good chance some CPU on the box is going to page fault. And when
> it does it hits the longjmp code and assumes the context of the oopsing CPU.
> The machine gets very confused when it has 10 CPUs all with the same stack,
> all thinking they have the same CPU id. I get even more confused trying
> to debug it.
Lol, guess that one didn't get tested that well :)
Fix looks good.
cheers
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2010-05-11 4:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-11 2:23 [PATCH 1/3] powerpc: kdump: Fix NULL pointer dereference in irq disable code Anton Blanchard
2010-05-11 2:25 ` [PATCH 2/3] powerpc: kdump: CPUs assume the context of the oopsing CPU Anton Blanchard
2010-05-11 2:27 ` [PATCH 3/3] powerpc: kdump: Use chip->shutdown to disable IRQs Anton Blanchard
2010-05-11 4:11 ` Michael Ellerman
2010-05-11 4:14 ` Michael Ellerman [this message]
2010-05-11 4:14 ` [PATCH 1/3] powerpc: kdump: Fix NULL pointer dereference in irq disable code Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1273551271.9209.135.camel@concordia \
--to=michael@ellerman.id.au \
--cc=anton@samba.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mikey@neuling.org \
--cc=miltonm@bga.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.