From: Luciano Coelho <luciano.coelho@nokia.com>
To: ext Dan Carpenter <error27@gmail.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
"Oikarinen Juuso (Nokia-D/Tampere)" <juuso.oikarinen@nokia.com>,
"Paasikivi Teemu.3 (EXT-Ixonos/Tampere)"
<ext-teemu.3.paasikivi@nokia.com>, Kalle Valo <kalle.valo@iki.fi>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [patch 7/9] wl1271: add missing spin_lock()
Date: Tue, 11 May 2010 07:27:17 +0300 [thread overview]
Message-ID: <1273552037.2021.25.camel@powerslave> (raw)
In-Reply-To: <20100508162517.GS27064@bicker>
On Sat, 2010-05-08 at 18:25 +0200, ext Dan Carpenter wrote:
> We should start the loop consistently with the "wl_lock" lock held.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> diff --git a/drivers/net/wireless/wl12xx/wl1271_main.c b/drivers/net/wireless/wl12xx/wl1271_main.c
> index 3e4b9fb..b61cd10 100644
> --- a/drivers/net/wireless/wl12xx/wl1271_main.c
> +++ b/drivers/net/wireless/wl12xx/wl1271_main.c
> @@ -466,6 +466,7 @@ static void wl1271_irq_work(struct work_struct *work)
> intr = le32_to_cpu(wl->fw_status->intr);
> if (!intr) {
> wl1271_debug(DEBUG_IRQ, "Zero interrupt received.");
> + spin_lock_irqsave(&wl->wl_lock, flags);
> continue;
> }
>
Good catch. Thank you.
Acked-by: Luciano Coelho <luciano.coelho@nokia.com>
--
Cheers,
Luca.
prev parent reply other threads:[~2010-05-11 4:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-08 16:25 [patch 7/9] wl1271: add missing spin_lock() Dan Carpenter
2010-05-11 4:27 ` Luciano Coelho [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1273552037.2021.25.camel@powerslave \
--to=luciano.coelho@nokia.com \
--cc=error27@gmail.com \
--cc=ext-teemu.3.paasikivi@nokia.com \
--cc=juuso.oikarinen@nokia.com \
--cc=kalle.valo@iki.fi \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.