From: Peter Zijlstra <peterz@infradead.org>
To: rostedt@goodmis.org
Cc: Ian Munsie <imunsie@au1.ibm.com>,
linux-kernel@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
Ingo Molnar <mingo@elte.hu>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Tom Zanussi <tzanussi@gmail.com>
Subject: Re: [PATCH 2/7] perf trace: Correctly handle arrays
Date: Fri, 14 May 2010 12:39:46 +0200 [thread overview]
Message-ID: <1273833586.1626.244.camel@laptop> (raw)
In-Reply-To: <1273768374.27703.1101.camel@gandalf.stny.rr.com>
On Thu, 2010-05-13 at 12:32 -0400, Steven Rostedt wrote:
>
> -- Steve
>
> > + else
> > + field->elementsize = field->size;
> > +
> > *fields = field;
> > fields = &field->next;
> >
> > @@ -2101,7 +2109,8 @@ static unsigned long long eval_num_arg(void *data, int size,
> > }
> > right = eval_num_arg(data, size, event, arg->op.right);
> > val = read_size(data + larg->field.field->offset +
> > - right * long_size, long_size);
> > + right * larg->field.field->elementsize,
> > + larg->field.field->elementsize);
> > break;
> > }
> > default_op:
> > diff --git a/tools/perf/util/trace-event.h b/tools/perf/util/trace-event.h
> > index 406d452..cc58a19 100644
> > --- a/tools/perf/util/trace-event.h
> > +++ b/tools/perf/util/trace-event.h
> > @@ -40,6 +40,8 @@ struct format_field {
> > char *name;
> > int offset;
> > int size;
> > + unsigned int arraylen;
> > + unsigned int elementsize;
> > unsigned long flags;
> > };
> >
What's with this new fad of not trimming emails?
next prev parent reply other threads:[~2010-05-14 10:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-13 6:03 perf trace: Fix array handling & value truncation Ian Munsie
2010-05-13 6:03 ` [PATCH 1/7] perf trace: Defensive programming Ian Munsie
2010-05-13 6:03 ` [PATCH 2/7] perf trace: Correctly handle arrays Ian Munsie
2010-05-13 16:29 ` Steven Rostedt
2010-05-15 3:20 ` Frederic Weisbecker
2010-05-13 16:32 ` Steven Rostedt
2010-05-14 10:39 ` Peter Zijlstra [this message]
2010-05-14 12:54 ` Steven Rostedt
2010-05-13 6:03 ` [PATCH 3/7] Revert "perf: Fix warning while reading ring buffer headers" Ian Munsie
2010-05-15 3:39 ` Frederic Weisbecker
2010-05-13 6:03 ` [PATCH 4/7] perf trace: Rewind pointer in case field in header_page is missing Ian Munsie
2010-05-13 6:03 ` [PATCH 5/7] perf trace: use long_size from trace-event-read Ian Munsie
2010-05-13 6:03 ` [PATCH 6/7] perf trace: Fix value truncation with 64bit kernel and 32bit userspace Ian Munsie
2010-05-13 6:03 ` [PATCH 7/7] perf trace test: Test cases for kernel->host format string conversion Ian Munsie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1273833586.1626.244.camel@laptop \
--to=peterz@infradead.org \
--cc=acme@redhat.com \
--cc=fweisbec@gmail.com \
--cc=imunsie@au1.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=rostedt@goodmis.org \
--cc=tzanussi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.