From: Stefani Seibold <stefani@seibold.net>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, andi@firstfloor.org,
gregkh@suse.de, alan@lxorguk.ukuu.org.uk, tytso@mit.edu,
iws@ovro.caltech.edu
Subject: Re: [PATCH 4/4] add example files to the kernel sample directory
Date: Sat, 15 May 2010 15:33:38 +0200 [thread overview]
Message-ID: <1273930418.32082.12.camel@wall-e.seibold.net> (raw)
In-Reply-To: <20100514134609.54e05968.akpm@linux-foundation.org>
Hi,
is the patch 0003-replace-the-old-non-generic-API.patch correct applied?
This patch renames the files created by patch
0002-add-the-new-generic-kfifo-API.patch
from
kernel/kfifo-new.c into kernel/kfifo.c
and
include/linux/kfifo-new.h into include/linux/kfifo.h.
Both destination files still exists, so git must overwrite them. This
was done in request by Greg, not to break the kernel build at this point
in the patch sequence.
Stefani
Am Freitag, den 14.05.2010, 13:46 -0700 schrieb Andrew Morton:
> On Wed, 12 May 2010 10:49:27 +0200
> stefani@seibold.net wrote:
>
> > This patch add four examples to the kernel sample directory.
>
> x86_64 allmodconfig:
>
> samples/kfifo/dma-example.c: In function 'example_init':
> samples/kfifo/dma-example.c:27: error: array type has incomplete element type
> samples/kfifo/dma-example.c:41: error: implicit declaration of function 'kfifo_put'
> samples/kfifo/dma-example.c:44: error: implicit declaration of function 'kfifo_get'
> samples/kfifo/dma-example.c:48: error: implicit declaration of function 'kfifo_dma_in_prepare'
> samples/kfifo/dma-example.c:48: warning: type defaults to 'int' in declaration of 'type name'
> samples/kfifo/dma-example.c:48: warning: type defaults to 'int' in declaration of 'type name'
> samples/kfifo/dma-example.c:48: error: negative width in bit-field '<anonymous>'
> samples/kfifo/dma-example.c:54: warning: type defaults to 'int' in declaration of 'type name'
> samples/kfifo/dma-example.c:54: warning: type defaults to 'int' in declaration of 'type name'
> samples/kfifo/dma-example.c:54: error: negative width in bit-field '<anonymous>'
> samples/kfifo/dma-example.c:60: error: implicit declaration of function 'sg_is_last'
> samples/kfifo/dma-example.c:71: error: implicit declaration of function 'kfifo_dma_in_finish'
> samples/kfifo/dma-example.c:74: error: implicit declaration of function 'kfifo_dma_out_prepare'
> samples/kfifo/dma-example.c:74: warning: type defaults to 'int' in declaration of 'type name'
> samples/kfifo/dma-example.c:74: warning: type defaults to 'int' in declaration of 'type name'
> samples/kfifo/dma-example.c:74: error: negative width in bit-field '<anonymous>'
> samples/kfifo/dma-example.c:80: warning: type defaults to 'int' in declaration of 'type name'
> samples/kfifo/dma-example.c:80: warning: type defaults to 'int' in declaration of 'type name'
> samples/kfifo/dma-example.c:80: error: negative width in bit-field '<anonymous>'
> samples/kfifo/dma-example.c:97: error: implicit declaration of function 'kfifo_dma_out_finish'
> samples/kfifo/dma-example.c:27: warning: unused variable 'sg'
> make[2]: *** [samples/kfifo/dma-example.o] Error 1
> make[2]: *** Waiting for unfinished jobs....
> samples/kfifo/bytestream-example.c:44:52: error: macro "DECLARE_KFIFO" passed 3 arguments, but takes just 2
> samples/kfifo/bytestream-example.c:44: warning: type defaults to 'int' in declaration of 'DECLARE_KFIFO'
> samples/kfifo/bytestream-example.c: In function 'testfunc':
> samples/kfifo/bytestream-example.c:56: error: 'test' undeclared (first use in this function)
> samples/kfifo/bytestream-example.c:56: error: (Each undeclared identifier is reported only once
> samples/kfifo/bytestream-example.c:56: error: for each function it appears in.)
> samples/kfifo/bytestream-example.c:60: error: implicit declaration of function 'kfifo_put'
> samples/kfifo/bytestream-example.c:83: error: implicit declaration of function 'kfifo_get'
> samples/kfifo/bytestream-example.c: In function 'fifo_write':
> samples/kfifo/bytestream-example.c:99: error: 'test' undeclared (first use in this function)
> samples/kfifo/bytestream-example.c: In function 'fifo_read':
> samples/kfifo/bytestream-example.c:115: error: 'test' undeclared (first use in this function)
> samples/kfifo/bytestream-example.c: In function 'example_init':
> samples/kfifo/bytestream-example.c:139: error: 'test' undeclared (first use in this function)
> samples/kfifo/bytestream-example.c:139: error: 'testkfifo_buffer' undeclared (first use in this function)
> make[2]: *** [samples/kfifo/bytestream-example.o] Error 1
> samples/kfifo/record-example.c:53: error: syntax error before numeric constant
> samples/kfifo/record-example.c:53: warning: type defaults to 'int' in declaration of 'mytest'
> samples/kfifo/record-example.c:53: warning: data definition has no type or storage class
> samples/kfifo/record-example.c:55: error: syntax error before 'test'
> samples/kfifo/record-example.c:55: warning: type defaults to 'int' in declaration of 'test'
> samples/kfifo/record-example.c:55: warning: data definition has no type or storage class
> samples/kfifo/record-example.c: In function 'testfunc':
> samples/kfifo/record-example.c:67: warning: passing argument 1 of 'kfifo_in' from incompatible pointer type
> samples/kfifo/record-example.c:70: error: implicit declaration of function 'kfifo_peek_len'
> samples/kfifo/record-example.c:75: warning: passing argument 1 of 'kfifo_in' from incompatible pointer type
> samples/kfifo/record-example.c:78: warning: passing argument 1 of 'kfifo_len' from incompatible pointer type
> samples/kfifo/record-example.c:81: warning: passing argument 1 of 'kfifo_out_peek' from incompatible pointer type
> samples/kfifo/record-example.c:81: error: too few arguments to function 'kfifo_out_peek'
> samples/kfifo/record-example.c:86: warning: passing argument 1 of 'kfifo_is_empty' from incompatible pointer type
> samples/kfifo/record-example.c:87: warning: passing argument 1 of 'kfifo_out' from incompatible pointer type
> samples/kfifo/record-example.c: In function 'fifo_write':
> samples/kfifo/record-example.c:103: warning: passing argument 1 of 'kfifo_from_user' from incompatible pointer type
> samples/kfifo/record-example.c: In function 'fifo_read':
> samples/kfifo/record-example.c:119: warning: passing argument 1 of 'kfifo_to_user' from incompatible pointer type
> samples/kfifo/record-example.c: In function 'example_init':
> samples/kfifo/record-example.c:143: error: 'testkfifo_buffer' undeclared (first use in this function)
> samples/kfifo/record-example.c:143: error: (Each undeclared identifier is reported only once
> samples/kfifo/record-example.c:143: error: for each function it appears in.)
> samples/kfifo/record-example.c:143: error: incompatible types in assignment
> make[2]: *** [samples/kfifo/record-example.o] Error 1
> samples/kfifo/inttype-example.c:44:41: error: macro "DEFINE_KFIFO" passed 3 arguments, but takes just 2
> samples/kfifo/inttype-example.c:44: warning: type defaults to 'int' in declaration of 'DEFINE_KFIFO'
> samples/kfifo/inttype-example.c: In function 'testfunc':
> samples/kfifo/inttype-example.c:57: error: implicit declaration of function 'kfifo_put'
> samples/kfifo/inttype-example.c:57: error: 'test' undeclared (first use in this function)
> samples/kfifo/inttype-example.c:57: error: (Each undeclared identifier is reported only once
> samples/kfifo/inttype-example.c:57: error: for each function it appears in.)
> samples/kfifo/inttype-example.c:75: error: implicit declaration of function 'kfifo_peek'
> samples/kfifo/inttype-example.c:79: error: implicit declaration of function 'kfifo_get'
> samples/kfifo/inttype-example.c: In function 'fifo_write':
> samples/kfifo/inttype-example.c:95: error: 'test' undeclared (first use in this function)
> samples/kfifo/inttype-example.c: In function 'fifo_read':
> samples/kfifo/inttype-example.c:111: error: 'test' undeclared (first use in this function)
>
next prev parent reply other threads:[~2010-05-15 13:33 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-12 8:49 really generic, type save and type definable stefani
2010-05-12 8:49 ` [PATCH 1/4] fix kfifo miss use of nozami.c stefani
2010-05-12 8:49 ` [PATCH 2/4] add the new generic kfifo API stefani
2010-05-29 18:30 ` Ira W. Snyder
2010-05-29 18:48 ` Stefani Seibold
2010-05-29 19:09 ` Ira W. Snyder
2010-05-12 8:49 ` [PATCH 3/4] replace the old non generic API stefani
2010-05-12 8:49 ` [PATCH 4/4] add example files to the kernel sample directory stefani
2010-05-14 20:46 ` Andrew Morton
2010-05-15 13:33 ` Stefani Seibold [this message]
2010-05-15 13:39 ` Andrew Morton
2010-05-28 7:43 ` really generic, type save and type definable Henrik Rydberg
2010-05-28 10:32 ` Stefani Seibold
2010-05-28 11:11 ` Henrik Rydberg
-- strict thread matches above, loose matches on Subject: below --
2010-08-10 6:40 [PATCH 0/4] enhanced reimplemention of the kfifo API stefani
2010-08-10 6:40 ` [PATCH 4/4] add example files to the kernel sample directory stefani
2010-07-20 13:05 [PATCH 0/4] enhanced reimplemention of the kfifo API stefani
2010-07-20 13:05 ` [PATCH 4/4] add example files to the kernel sample directory stefani
2010-04-20 20:06 [PATCH 0/4] enhanced reimplemention of the kfifo API stefani
2010-04-20 20:06 ` [PATCH 4/4] add example files to the kernel sample directory stefani
2010-04-18 21:05 [PATCH 0/4] enhanced reimplemention of the kfifo API stefani
2010-04-18 21:05 ` [PATCH 4/4] add example files to the kernel sample directory stefani
2010-04-18 20:54 [PATCH 0/4] enhanced reimplemention of the kfifo API stefani
2010-04-18 20:54 ` [PATCH 4/4] add example files to the kernel sample directory stefani
2010-02-12 7:52 [PATCH 0/4] enhanced reimplemention of the kfifo API Stefani Seibold
2010-02-12 8:07 ` [PATCH 4/4] add example files to the kernel sample directory Stefani Seibold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1273930418.32082.12.camel@wall-e.seibold.net \
--to=stefani@seibold.net \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=andi@firstfloor.org \
--cc=gregkh@suse.de \
--cc=iws@ovro.caltech.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.