From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Yinghai <yinghai.lu@oracle.com>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Andrew Morton <akpm@linux-foundation.org>,
David Miller <davem@davemloft.net>,
Linus Torvalds <torvalds@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org
Subject: Re: [PATCH 07/37] lmb: Add lmb_find_area()
Date: Mon, 17 May 2010 10:48:49 +1000 [thread overview]
Message-ID: <1274057329.21352.709.camel@pasglop> (raw)
In-Reply-To: <4BEDD7D4.90002@oracle.com>
On Fri, 2010-05-14 at 16:08 -0700, Yinghai wrote:
> how about
> lmb_reserve_area ==> lmb_reserve_range
> lmb_free_area ==> lmb_free_range
I completely fail to see why you still need those two. They are exactly
the same thing as lmb_reserve() and lmb_free(), just with a slightly
different prototype.
> or leave them that way, later replace them lmb_reserve and lmb_free
> one by one?
Nah, if you have some use of the wrappers to ease the transition from
the existing x86 code, then just make up a couple of inline wrappers
somewhere inside the x86 code. You may not even want to call it
lmb_* at all...
But here, I'll let Thomas and Peter decide what to do, it's really
x86 stuff at this stage. I don't want to see two subtlely different
APIs at the LMB level doing the same thing.
Cheers,
Ben.
next prev parent reply other threads:[~2010-05-17 0:50 UTC|newest]
Thread overview: 81+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-14 19:45 [PATCH -v17 00/37] Use lmb with x86 Yinghai Lu
2010-05-14 19:45 ` Yinghai Lu
2010-05-14 19:45 ` [PATCH 01/37] lmb: lmb_find_base() should return LMB_ERROR on failing path Yinghai Lu
2010-05-14 19:45 ` Yinghai Lu
2010-05-14 19:45 ` [PATCH 02/37] lmb: Prepare x86 to use lmb to replace early_res Yinghai Lu
2010-05-14 19:45 ` Yinghai Lu
2010-05-14 19:45 ` [PATCH 03/37] lmb: Print new doubled array location info Yinghai Lu
2010-05-14 19:45 ` Yinghai Lu
2010-05-14 19:45 ` [PATCH 04/37] lmb: Export LMB_ERROR again Yinghai Lu
2010-05-14 19:45 ` Yinghai Lu
2010-05-14 19:45 ` [PATCH 05/37] lmb: Prepare to include linux/lmb.h in core file Yinghai Lu
2010-05-14 19:45 ` Yinghai Lu
2010-05-14 19:45 ` [PATCH 06/37] lmb: Add ARCH_DISCARD_LMB to put lmb code to .init Yinghai Lu
2010-05-14 19:45 ` Yinghai Lu
2010-05-14 19:45 ` [PATCH 07/37] lmb: Add lmb_find_area() Yinghai Lu
2010-05-14 19:45 ` Yinghai Lu
2010-05-14 22:39 ` Benjamin Herrenschmidt
2010-05-14 23:08 ` Yinghai
2010-05-15 0:11 ` Yinghai
2010-05-17 0:48 ` Benjamin Herrenschmidt [this message]
2010-05-17 6:09 ` Yinghai
2010-05-14 19:45 ` [PATCH 08/37] x86, lmb: Add lmb_find_area_size() Yinghai Lu
2010-05-14 19:45 ` Yinghai Lu
2010-05-14 19:45 ` [PATCH 09/37] bootmem, x86: Add weak version of reserve_bootmem_generic Yinghai Lu
2010-05-14 19:45 ` Yinghai Lu
2010-05-14 19:45 ` [PATCH 10/37] x86, lmb: Add lmb_to_bootmem() Yinghai Lu
2010-05-14 19:45 ` Yinghai Lu
2010-05-14 19:45 ` [PATCH 11/37] x86,lmb: Add lmb_reserve_area/lmb_free_area Yinghai Lu
2010-05-14 19:45 ` Yinghai Lu
2010-05-14 19:45 ` [PATCH 12/37] x86, lmb: Add get_free_all_memory_range() Yinghai Lu
2010-05-14 19:45 ` Yinghai Lu
2010-05-14 19:45 ` [PATCH 13/37] x86, lmb: Add lmb_register_active_regions() and lmb_hole_size() Yinghai Lu
2010-05-14 19:45 ` Yinghai Lu
2010-05-14 19:45 ` [PATCH 14/37] lmb: Add find_memory_core_early() Yinghai Lu
2010-05-14 19:45 ` Yinghai Lu
2010-05-14 19:45 ` [PATCH 15/37] x86, lmb: Add lmb_find_area_node() Yinghai Lu
2010-05-14 19:45 ` Yinghai Lu
2010-05-14 19:45 ` [PATCH 16/37] x86, lmb: Add lmb_free_memory_size() Yinghai Lu
2010-05-14 19:45 ` Yinghai Lu
2010-05-14 19:45 ` [PATCH 17/37] x86, lmb: Add lmb_memory_size() Yinghai Lu
2010-05-14 19:45 ` Yinghai Lu
2010-05-14 19:45 ` [PATCH 18/37] x86, lmb: Use lmb_debug to control debug message print out Yinghai Lu
2010-05-14 19:45 ` Yinghai Lu
2010-05-14 19:45 ` [PATCH 19/37] x86, lmb: Add x86 version of __lmb_find_area() Yinghai Lu
2010-05-14 19:45 ` Yinghai Lu
2010-05-14 19:45 ` [PATCH 20/37] x86: Use lmb to replace early_res Yinghai Lu
2010-05-14 19:45 ` Yinghai Lu
2010-05-14 19:45 ` [PATCH 21/37] x86: Replace e820_/_early string with lmb_ Yinghai Lu
2010-05-14 19:45 ` Yinghai Lu
2010-05-14 19:45 ` [PATCH 22/37] x86: Remove not used early_res code Yinghai Lu
2010-05-14 19:45 ` Yinghai Lu
2010-05-14 19:45 ` [PATCH 23/37] x86, lmb: Use lmb_memory_size()/lmb_free_memory_size() to get correct dma_reserve Yinghai Lu
2010-05-14 19:45 ` Yinghai Lu
2010-05-14 19:45 ` [PATCH 24/37] bootmem: Add nobootmem.c to reduce the #ifdef Yinghai Lu
2010-05-14 19:45 ` Yinghai Lu
2010-05-14 19:45 ` [PATCH 25/37] mm: move contig_page_data define to bootmem.c/nobootmem.c Yinghai Lu
2010-05-14 19:45 ` Yinghai Lu
2010-05-14 19:45 ` [PATCH 26/37] lmb: Move __alloc_memory_core_early() to nobootmem.c Yinghai Lu
2010-05-14 19:45 ` Yinghai Lu
2010-05-14 19:45 ` [PATCH 27/37] x86: Have nobootmem version setup_bootmem_allocator() Yinghai Lu
2010-05-14 19:45 ` Yinghai Lu
2010-05-14 19:45 ` [PATCH 28/37] x86: Put 64 bit numa node memmap above 16M Yinghai Lu
2010-05-14 19:45 ` Yinghai Lu
2010-05-14 19:45 ` [PATCH 29/37] swiotlb: Use page alignment for early buffer allocation Yinghai Lu
2010-05-14 19:45 ` Yinghai Lu
2010-05-14 19:45 ` [PATCH 30/37] x86: Add sanitize_e820_map() Yinghai Lu
2010-05-14 19:45 ` Yinghai Lu
2010-05-14 19:45 ` [PATCH 31/37] x86: Change e820_saved to __initdata Yinghai Lu
2010-05-14 19:45 ` Yinghai Lu
2010-05-14 19:45 ` [PATCH 32/37] x86: Align e820 ram range to page Yinghai Lu
2010-05-14 19:45 ` Yinghai Lu
2010-05-14 19:45 ` [PATCH 33/37] x86: Use wake_system_ram_range() instead of e820_any_mapped() in agp path Yinghai Lu
2010-05-14 19:45 ` Yinghai Lu
2010-05-14 19:46 ` [PATCH 34/37] x86: Add get_centaur_ram_top() Yinghai Lu
2010-05-14 19:46 ` Yinghai Lu
2010-05-14 19:46 ` [PATCH 35/37] x86: Change e820_any_mapped() to __init Yinghai Lu
2010-05-14 19:46 ` Yinghai Lu
2010-05-14 19:46 ` [PATCH 36/37] x86: Use walk_system_ream_range() instead of referring e820.map directly for tboot Yinghai Lu
2010-05-14 19:46 ` Yinghai Lu
2010-05-14 19:46 ` [PATCH 37/37] x86: make e820 to be __initdata Yinghai Lu
2010-05-14 19:46 ` Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1274057329.21352.709.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=hannes@cmpxchg.org \
--cc=hpa@zytor.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=yinghai.lu@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.