From: <asheeshb@ti.com>
To: <linux-media@vger.kernel.org>
Cc: Asheesh Bhardwaj <asheesh@lab1.dmlab>
Subject: [PATCH 2/7] Patch for adding imagesize corrected for MMAP buffers and behave the same as user allocated buffers. The sizeimage parameter is giving the wrong size from the driver and it has to be corrected in S_FMT and TRY_FMT ioctls.
Date: Wed, 19 May 2010 10:56:46 -0500 [thread overview]
Message-ID: <1274284611-13432-2-git-send-email-asheeshb@ti.com> (raw)
In-Reply-To: <1274284611-13432-1-git-send-email-asheeshb@ti.com>
From: Asheesh Bhardwaj <asheesh@lab1.dmlab>
---
drivers/media/video/davinci/vpif_display.c | 23 ++++++++---------------
1 files changed, 8 insertions(+), 15 deletions(-)
diff --git a/drivers/media/video/davinci/vpif_display.c b/drivers/media/video/davinci/vpif_display.c
index db9f395..d794595 100644
--- a/drivers/media/video/davinci/vpif_display.c
+++ b/drivers/media/video/davinci/vpif_display.c
@@ -191,7 +191,8 @@ static int vpif_buffer_prepare(struct videobuf_queue *q,
if (VIDEOBUF_NEEDS_INIT == vb->state) {
vb->width = common->width;
vb->height = common->height;
- vb->size = vb->width * vb->height;
+ /* Updating the size based on the application requirement */
+ vb->size = common->fmt.fmt.pix.sizeimage;
vb->field = field;
ret = videobuf_iolock(q, vb, NULL);
@@ -480,11 +481,8 @@ static void vpif_calculate_offsets(struct channel_obj *ch)
} else {
vid_ch->buf_field = common->fmt.fmt.pix.field;
}
-
- if (V4L2_MEMORY_USERPTR == common->memory)
- sizeimage = common->fmt.fmt.pix.sizeimage;
- else
- sizeimage = config_params.channel_bufsize[ch->channel_id];
+
+ sizeimage = common->fmt.fmt.pix.sizeimage;
hpitch = common->fmt.fmt.pix.bytesperline;
vpitch = sizeimage / (hpitch * 2);
@@ -560,11 +558,9 @@ static int vpif_check_format(struct channel_obj *ch,
if (pixfmt->bytesperline <= 0)
goto invalid_pitch_exit;
-
- if (V4L2_MEMORY_USERPTR == common->memory)
- sizeimage = pixfmt->sizeimage;
- else
- sizeimage = config_params.channel_bufsize[ch->channel_id];
+
+ /* sizeimage is same for both MMAP and user allocated buffers, the size is updated for mmap buffers*/
+ sizeimage = pixfmt->sizeimage;
if (vpif_get_std_info(ch)) {
vpif_err("Error getting the standard info\n");
@@ -1107,10 +1103,7 @@ static int vpif_streamon(struct file *file, void *priv,
goto streamon_exit;
}
- if (common->memory == V4L2_MEMORY_MMAP)
- sizeimage = config_params.channel_bufsize[ch->channel_id];
- else
- sizeimage = common->fmt.fmt.pix.sizeimage;
+ sizeimage = common->fmt.fmt.pix.sizeimage;
if ((ch->vpifparams.std_info.width *
ch->vpifparams.std_info.height * 2) >
--
1.6.3.3
next prev parent reply other threads:[~2010-05-19 15:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-19 15:56 [PATCH 1/7] changed driver for MMAP buffer asheeshb
2010-05-19 15:56 ` asheeshb [this message]
2010-05-19 15:56 ` [PATCH 3/7] Patch for capture driver MMAP buffer allocation. The user can specify the size of the buffers with an offset from the kernel images asheeshb
2010-05-19 15:56 ` [PATCH 4/7] Patch for vpif capture driver to get the right size image for the MMAP buffers asheeshb
2010-05-19 15:56 ` [PATCH 5/7] DM365 MMAP buffer allocation for display driver asheeshb
2010-05-19 15:56 ` [PATCH 6/7] DM365 capture MMAP buffer allocation asheeshb
2010-05-19 15:56 ` [PATCH 7/7] Patch MMAP buffer bufsize support upto 1080p resolution on capture driver DM365 asheeshb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1274284611-13432-2-git-send-email-asheeshb@ti.com \
--to=asheeshb@ti.com \
--cc=asheesh@lab1.dmlab \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.