All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Roskin <proski@gnu.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: John Linville <linville@tuxdriver.com>, Jouni Malinen <j@w1.fi>,
	linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] cfg80211: make action channel type optional
Date: Wed, 19 May 2010 14:19:12 -0400	[thread overview]
Message-ID: <1274293152.8463.2.camel@mj> (raw)
In-Reply-To: <1274264232.3874.7.camel@jlt3.sipsolutions.net>

On Wed, 2010-05-19 at 12:17 +0200, Johannes Berg wrote:

> @@ -1168,6 +1168,7 @@ struct cfg80211_ops {
>  	int	(*action)(struct wiphy *wiphy, struct net_device *dev,
>  			  struct ieee80211_channel *chan,
>  			  enum nl80211_channel_type channel_type,
> +			  bool channel_type_valid,
>  			  const u8 *buf, size_t len, u64 *cookie);

Would not it be easier to introduce NL80211_CHAN_UNSPECIFIED in enum
nl80211_channel_type?

-- 
Regards,
Pavel Roskin

  reply	other threads:[~2010-05-19 18:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-19 10:17 [PATCH] cfg80211: make action channel type optional Johannes Berg
2010-05-19 18:19 ` Pavel Roskin [this message]
2010-05-19 18:48   ` Johannes Berg
2010-05-19 19:05     ` Pavel Roskin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1274293152.8463.2.camel@mj \
    --to=proski@gnu.org \
    --cc=j@w1.fi \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.