From: Peter Zijlstra <peterz@infradead.org>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@elte.hu>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
David Miller <davem@davemloft.net>
Subject: Re: [PATCH 2/2] perf: Drop the skip argument from perf_arch_fetch_regs_caller
Date: Fri, 21 May 2010 12:24:37 +0200 [thread overview]
Message-ID: <1274437477.1674.1698.camel@laptop> (raw)
In-Reply-To: <1274429477-21531-3-git-send-regression-fweisbec@gmail.com>
On Fri, 2010-05-21 at 10:11 +0200, Frederic Weisbecker wrote:
> +static inline void perf_fetch_caller_regs(struct pt_regs *regs)
> {
> - unsigned long ip;
> -
> memset(regs, 0, sizeof(*regs));
btw, do we really need that memset?
As long as we don't actually copy out to userspace, it really doesn't
matter what is in there, and we should be setting all relevant registers
anyway.
next prev parent reply other threads:[~2010-05-21 10:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-21 8:11 [PATCH 0/2] perf: perf_arch_fetch_regs_caller API change Frederic Weisbecker
2010-05-21 8:11 ` [PATCH 1/2] x86: Unify dumpstack.h and stacktrace.h Frederic Weisbecker
2010-05-21 8:11 ` [PATCH 2/2] perf: Drop the skip argument from perf_arch_fetch_regs_caller Frederic Weisbecker
2010-05-21 10:24 ` Peter Zijlstra [this message]
2010-05-21 10:29 ` Frederic Weisbecker
-- strict thread matches above, loose matches on Subject: below --
2010-05-25 13:45 [GIT PULL] perf updates Frederic Weisbecker
2010-05-25 13:45 ` [PATCH 2/2] perf: Drop the skip argument from perf_arch_fetch_regs_caller Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1274437477.1674.1698.camel@laptop \
--to=peterz@infradead.org \
--cc=acme@redhat.com \
--cc=davem@davemloft.net \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.