From: Marcel Holtmann <marcel@holtmann.org>
To: ofono@ofono.org
Subject: Re: [PATCH 2/9] Remove hack around hfp agent interface
Date: Tue, 25 May 2010 09:53:39 +0200 [thread overview]
Message-ID: <1274774019.27220.119.camel@localhost.localdomain> (raw)
In-Reply-To: <20100525074952.GA2710@vigoh>
[-- Attachment #1: Type: text/plain, Size: 633 bytes --]
Hi Gustavo,
> > In the past we did this dirty hack to quickly fix HFP for the release, now
> > fixing it in a proper way.
> > ---
> > drivers/hfpmodem/hfpmodem.h | 1 -
> > plugins/hfp.c | 12 +++---------
> > 2 files changed, 3 insertions(+), 10 deletions(-)
> >
>
>
> The first two were refused. The following patches still apply cleanly from
> here.
send the debug option change separately (and also for ConnMan of course)
and then the rest as its own series. Intermixing multiple patches of
different types is a bad idea since everybody gets lost at some point.
Regards
Marcel
prev parent reply other threads:[~2010-05-25 7:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-25 7:17 patches for DUN, HFP and gdbus Gustavo F. Padovan
2010-05-25 7:18 ` [PATCH 1/9] Add g_dbus_interface_is_registered() Gustavo F. Padovan
2010-05-25 7:18 ` [PATCH 2/9] Remove hack around hfp agent interface Gustavo F. Padovan
2010-05-25 7:18 ` [PATCH 3/9] Bring back -d option without need for argument Gustavo F. Padovan
2010-05-25 7:18 ` [PATCH 4/9] Add bluetooth plugin skeleton Gustavo F. Padovan
2010-05-25 7:18 ` [PATCH 5/9] Move bluetooth utils from hfp.c to bluetooth.c Gustavo F. Padovan
2010-05-25 7:18 ` [PATCH 6/9] Remove send_method_call from hfp.c Gustavo F. Padovan
2010-05-25 7:18 ` [PATCH 7/9] Move create_path() to bluetooth plugin Gustavo F. Padovan
2010-05-25 7:18 ` [PATCH 8/9] Change hfpmodem's header define Gustavo F. Padovan
2010-05-25 7:18 ` [PATCH 9/9] Bluetooth DUN modem prototype Gustavo F. Padovan
2010-05-25 10:17 ` [PATCH 5/9] Move bluetooth utils from hfp.c to bluetooth.c Zhang, Zhenhua
2010-05-25 7:49 ` [PATCH 2/9] Remove hack around hfp agent interface Gustavo F. Padovan
2010-05-25 7:53 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1274774019.27220.119.camel@localhost.localdomain \
--to=marcel@holtmann.org \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.