From: Richard Purdie <rpurdie@rpsys.net>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
John Lenz <lenz@cs.wisc.edu>
Subject: Re: [PATCH] led-class: set permissions on max_brightness file to 0444
Date: Wed, 26 May 2010 12:28:05 +0100 [thread overview]
Message-ID: <1274873285.16229.83.camel@rex> (raw)
In-Reply-To: <1274057308.9060.3.camel@mola>
On Mon, 2010-05-17 at 08:48 +0800, Axel Lin wrote:
> max_brightness is not writable, thus set permissions to 0444.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> drivers/leds/led-class.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c
> index 69e7d86..2606600 100644
> --- a/drivers/leds/led-class.c
> +++ b/drivers/leds/led-class.c
> @@ -74,7 +74,7 @@ static ssize_t led_max_brightness_show(struct device *dev,
>
> static struct device_attribute led_class_attrs[] = {
> __ATTR(brightness, 0644, led_brightness_show, led_brightness_store),
> - __ATTR(max_brightness, 0644, led_max_brightness_show, NULL),
> + __ATTR(max_brightness, 0444, led_max_brightness_show, NULL),
> #ifdef CONFIG_LEDS_TRIGGERS
> __ATTR(trigger, 0644, led_trigger_show, led_trigger_store),
> #endif
Queued in the leds tree, thanks.
Richard
prev parent reply other threads:[~2010-05-26 11:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-17 0:48 [PATCH] led-class: set permissions on max_brightness file to 0444 Axel Lin
2010-05-26 11:28 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1274873285.16229.83.camel@rex \
--to=rpurdie@rpsys.net \
--cc=axel.lin@gmail.com \
--cc=lenz@cs.wisc.edu \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.