From: Michael Ellerman <michael@ellerman.id.au>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] powerpc/fsl-booke: Move loadcam_entry back to asm code to fix SMP ftrace
Date: Thu, 27 May 2010 00:59:30 +1000 [thread overview]
Message-ID: <1274885970.21113.6.camel@concordia> (raw)
In-Reply-To: <1274726319-4673-3-git-send-email-galak@kernel.crashing.org>
[-- Attachment #1: Type: text/plain, Size: 536 bytes --]
On Mon, 2010-05-24 at 13:38 -0500, Kumar Gala wrote:
> When we build with ftrace enabled its possible that loadcam_entry would
> have used the stack pointer (even though the code doesn't need it). We
> call loadcam_entry in __secondary_start before the stack is setup. To
> ensure that loadcam_entry doesn't use the stack pointer the easiest
> solution is to just have it in asm code.
You could move it to a separate file and have that not built with the
ftrace options (-pg etc.) - but maybe that's not easier.
cheers
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2010-05-26 14:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-24 18:38 [PATCH] powerpc: Fix ioremap_flags() with book3e pte definition Kumar Gala
2010-05-24 18:38 ` [PATCH] powerpc/fsl-booke: Fix InstructionTLBError execute permission check Kumar Gala
2010-05-24 18:38 ` [PATCH] powerpc/fsl-booke: Move loadcam_entry back to asm code to fix SMP ftrace Kumar Gala
2010-05-26 14:59 ` Michael Ellerman [this message]
2010-06-02 21:59 ` [PATCH] powerpc: Fix ioremap_flags() with book3e pte definition Kumar Gala
2010-06-02 22:02 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2010-05-14 4:25 [PATCH] powerpc/fsl-booke: Move loadcam_entry back to asm code to fix SMP ftrace Kumar Gala
2010-05-14 15:18 ` Becky Bruce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1274885970.21113.6.camel@concordia \
--to=michael@ellerman.id.au \
--cc=galak@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.