All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Joerg Pommnitz <pommnitz@yahoo.com>
Cc: linux-wireless@vger.kernel.org, Holger Schurig <holgerschurig@gmail.com>
Subject: Re: [RFC] mac80211: sample survey implementation for mac80211 &amp; hwsim
Date: Wed, 26 May 2010 22:43:32 +0200	[thread overview]
Message-ID: <1274906612.3658.58.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <loom.20100422T100127-458@post.gmane.org>

Holger,

> > +static int ieee80211_dump_survey(struct wiphy *wiphy, struct net_device *dev,
> > +				 int idx, struct survey_info *survey)
> > +{
> > +	struct ieee80211_local *local = wdev_priv(dev->ieee80211_ptr);
> > +
> > +	if (!local->ops->get_survey)
> > +		return -EOPNOTSUPP;
> 
> The check for the function is duplicated in drv_get_survey. I think the
> wrapper should be called unconditionally.

Please address this comment and add tracing. Your patch was merged, so
that needs to be an add-on patch.

johannes


  reply	other threads:[~2010-05-26 20:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-19  8:23 [RFC] mac80211: sample survey implementation for mac80211 & hwsim Holger Schurig
2010-04-19  8:58 ` Holger Schurig
2010-04-19  9:02 ` Johannes Berg
2010-04-22  8:04 ` [RFC] mac80211: sample survey implementation for mac80211 &amp; hwsim Joerg Pommnitz
2010-05-26 20:43   ` Johannes Berg [this message]
2010-06-29 19:00     ` [PATCH] mac80211: remove unnecessary check in ieee80211_dump_survey John W. Linville
2010-06-29 19:00     ` [PATCH] mac80211: add basic tracing to drv_get_survey John W. Linville

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1274906612.3658.58.camel@jlt3.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=holgerschurig@gmail.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=pommnitz@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.