All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Skeggs <bskeggs-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Marcin Slusarz <marcin.slusarz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: "typo" in "drm/nv50: cast IGP memory location to u64 before shifting"
Date: Wed, 02 Jun 2010 08:40:01 +1000	[thread overview]
Message-ID: <1275432001.3727.0.camel@nisroch> (raw)
In-Reply-To: <20100601164633.GA2854-OI9uyE9O0yo@public.gmane.org>

On Tue, 2010-06-01 at 18:46 +0200, Marcin Slusarz wrote:
> Hi
> 
> This does not look right:
> 
> diff --git a/drivers/gpu/drm/nouveau/nouveau_mem.c b/drivers/gpu/drm/nouveau/nouveau_mem.c
> index 775a701..c1fd42b 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_mem.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_mem.c
> @@ -540,7 +540,8 @@ nouveau_mem_detect(struct drm_device *dev)
>  		dev_priv->vram_size  = nv_rd32(dev, NV04_FIFO_DATA);
>  		dev_priv->vram_size &= NV10_FIFO_DATA_RAM_AMOUNT_MB_MASK;
>  		if (dev_priv->chipset == 0xaa || dev_priv->chipset == 0xac)
> -			dev_priv->vram_sys_base = nv_rd32(dev, 0x100e10) << 12;
> +			dev_priv->vram_sys_base = nv_rd32(dev, 0x100e10);
> +			dev_priv->vram_sys_base <<= 12;
>  	}
>  
>  	NV_INFO(dev, "Detected %dMiB VRAM\n", (int)(dev_priv->vram_size >> 20));
> 
> You forgot to add {} around these lines...
Oops, fail.  Luckily it doesn't actually matter at all in this case, but
I've fixed it anyway.

Thanks!
Ben.
> 
> Marcin
> 
> _______________________________________________
> Nouveau mailing list
> Nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
> http://lists.freedesktop.org/mailman/listinfo/nouveau

      parent reply	other threads:[~2010-06-01 22:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-01 16:46 "typo" in "drm/nv50: cast IGP memory location to u64 before shifting" Marcin Slusarz
     [not found] ` <20100601164633.GA2854-OI9uyE9O0yo@public.gmane.org>
2010-06-01 22:40   ` Ben Skeggs [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1275432001.3727.0.camel@nisroch \
    --to=bskeggs-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=marcin.slusarz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.