All of lore.kernel.org
 help / color / mirror / Atom feed
From: <gregkh@suse.de>
To: randy.dunlap@oracle.com, gregkh@suse.de,
	linux-kernel@vger.kernel.org, sfr@canb.auug.org.au
Subject: patch staging-phison-depends-on-ata_bmdma.patch added to gregkh-2.6 tree
Date: Thu, 03 Jun 2010 11:09:16 -0700	[thread overview]
Message-ID: <12755885561990@site> (raw)
In-Reply-To: <20100526103002.ac2c6703.randy.dunlap@oracle.com>


This is a note to let you know that I've just added the patch titled

    Subject: Staging: phison: depends on ATA_BMDMA

to my gregkh-2.6 tree.  Its filename is

    staging-phison-depends-on-ata_bmdma.patch

This tree can be found at 
    http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/patches/


>From randy.dunlap@oracle.com  Tue Jun  1 14:14:50 2010
From: Randy Dunlap <randy.dunlap@oracle.com>
Date: Wed, 26 May 2010 10:30:02 -0700
Subject: Staging: phison: depends on ATA_BMDMA
To: Stephen Rothwell <sfr@canb.auug.org.au>, gregkh@suse.de
Cc: linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>, evan_ko@phison.com
Message-ID: <20100526103002.ac2c6703.randy.dunlap@oracle.com>


From: Randy Dunlap <randy.dunlap@oracle.com>

phison uses interfaces and data that are built only when
ATA_BMDMA is enabled, so it should depend on that symbol.

drivers/staging/phison/phison.c:43: error: implicit declaration of function 'ATA_BMDMA_SHT'
drivers/staging/phison/phison.c:43: error: initializer element is not constant
drivers/staging/phison/phison.c:43: error: (near initialization for 'phison_sht.module')
drivers/staging/phison/phison.c:47: error: 'ata_bmdma_port_ops' undeclared here (not in a function)

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: evan_ko@phison.com
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

---
 drivers/staging/phison/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/staging/phison/Kconfig
+++ b/drivers/staging/phison/Kconfig
@@ -1,5 +1,5 @@
 config IDE_PHISON
 	tristate "PCIE ATA PS5000 IDE support"
-	depends on PCI && ATA && ATA_SFF
+	depends on PCI && ATA && ATA_SFF && ATA_BMDMA
 	---help---
 	  This is an experimental driver for PS5000 IDE driver.


      reply	other threads:[~2010-06-03 18:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-26  5:34 linux-next: Tree for May 26 Stephen Rothwell
2010-05-26 17:08 ` [PATCH -next] media/IR: nec-decoder needs to select BITREV Randy Dunlap
2010-05-26 17:30 ` [PATCH -next] staging/phison: depends on ATA_BMDMA Randy Dunlap
2010-06-03 18:09   ` gregkh [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12755885561990@site \
    --to=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=randy.dunlap@oracle.com \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.