From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Wan ZongShun <mcuos.com@gmail.com>
Cc: alsa-devel <alsa-devel@alsa-project.org>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
zswan@marvell.com
Subject: Re: [PATCH] ASoC/kirkwood: patch for the useless 'break' removal.
Date: Mon, 07 Jun 2010 13:53:21 +0100 [thread overview]
Message-ID: <1275915201.3045.107.camel@odin> (raw)
In-Reply-To: <AANLkTimHsGoR4aonANTBFaTgZmXA2jZlYJ5q5WA_3gab@mail.gmail.com>
On Sat, 2010-06-05 at 15:04 +0800, Wan ZongShun wrote:
> Hi Mark,
>
> How about this patch?
> My other patch seem to be applied, but this one still be hung.
>
> 在 2010年6月2日 下午4:03，Wan ZongShun <mcuos.com@gmail.com> 写道：
> > This patch to remove the 'break;', when the 'switch' jumps to
> > the 'default' branch, the 'return -EINVAL' will be return with
> > a error number, so the 'break;' code never be run, it is unuseful
> > and should be removed here.
> >
> >
> > Signed-off-by: Wan ZongShun<mcuos.com@gmail.com>
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2010-06-07 12:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4C06105B.2060702@gmail.com>
2010-06-05 7:04 ` [PATCH] ASoC/kirkwood: patch for the useless 'break' removal Wan ZongShun
2010-06-07 12:53 ` Liam Girdwood [this message]
2010-06-07 13:28 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1275915201.3045.107.camel@odin \
--to=lrg@slimlogic.co.uk \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=mcuos.com@gmail.com \
--cc=zswan@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.