All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Bruno Randolf <br1@einfach.org>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH v3 1/3] cfg80211: Add nl80211 antenna configuration
Date: Tue, 08 Jun 2010 09:27:28 +0200	[thread overview]
Message-ID: <1275982048.3706.2.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <201006081019.10217.br1@einfach.org>

On Tue, 2010-06-08 at 10:19 +0900, Bruno Randolf wrote:

> > > +	res = rdev->ops->get_antenna(&rdev->wiphy, &tx_ant, &rx_ant);
> > > +	if (res)
> > > +		goto free_msg;
> > 
> > and complain about the driver if they still are after this.
> 
> would that be a WARN_ON?

Yeah I suppose so.

johannes


  reply	other threads:[~2010-06-08  7:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-07  6:58 [PATCH v3 1/3] cfg80211: Add nl80211 antenna configuration Bruno Randolf
2010-06-07  6:59 ` [PATCH v3 2/3] mac80211: Add " Bruno Randolf
2010-06-07  6:59 ` [PATCH v3 3/3] ath5k: Add support for " Bruno Randolf
2010-06-07  9:03 ` [PATCH v3 1/3] cfg80211: Add nl80211 " Johannes Berg
2010-06-08  1:19   ` Bruno Randolf
2010-06-08  7:27     ` Johannes Berg [this message]
2010-06-07  9:05 ` Johannes Berg
2010-06-08  1:10   ` Bruno Randolf
2010-06-08  9:05     ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1275982048.3706.2.camel@jlt3.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=br1@einfach.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.