From mboxrd@z Thu Jan 1 00:00:00 1970 From: Liam Girdwood Subject: Re: [PATCH 2/2] pxa: modify the pxa2xx-ac97 file for pxa168 Date: Tue, 08 Jun 2010 16:01:55 +0100 Message-ID: <1276009315.3003.346.camel@odin> References: <4C0E21A1.4000909@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ww0-f51.google.com (mail-ww0-f51.google.com [74.125.82.51]) by alsa0.perex.cz (Postfix) with ESMTP id 278FB103902 for ; Tue, 8 Jun 2010 17:02:02 +0200 (CEST) Received: by wwf26 with SMTP id 26so3368029wwf.38 for ; Tue, 08 Jun 2010 08:02:01 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Wan ZongShun Cc: alsa-devel , Mark Brown , Eric Miao , linux-arm-kernel List-Id: alsa-devel@alsa-project.org On Tue, 2010-06-08 at 22:49 +0800, Wan ZongShun wrote: > 2010/6/8 Eric Miao : > > 2010/6/8 Wan ZongShun : > >> In order to allow the sharing of the pxa2xx-ac97 driver file with pxa168, > >> we have to do a little change to pxa2xx-ac97 file. > >> > >> All private register addresses were located in mach/include/ac97.h. > > > > This is not the right way to go, as suggested already. I hope the ac97 > > driver is more self-contained. i.e. having a platform device for: > > > > - where the registers are mapped from > > - drcmr channel numbers can be encoded within dma resource > > - ac97 register definitions are not exposed everywhere > > > > Got it, so I should put above to platform_device and remove regs-ac97.h, > any private bit definition should be removed to driver directory as > driver _only_. > ...and could you also CC Mark on any ASoC related changes too. Thanks Liam -- Freelance Developer, SlimLogic Ltd ASoC and Voltage Regulator Maintainer. http://www.slimlogic.co.uk From mboxrd@z Thu Jan 1 00:00:00 1970 From: lrg@slimlogic.co.uk (Liam Girdwood) Date: Tue, 08 Jun 2010 16:01:55 +0100 Subject: [PATCH 2/2] pxa: modify the pxa2xx-ac97 file for pxa168 In-Reply-To: References: <4C0E21A1.4000909@gmail.com> Message-ID: <1276009315.3003.346.camel@odin> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, 2010-06-08 at 22:49 +0800, Wan ZongShun wrote: > 2010/6/8 Eric Miao : > > 2010/6/8 Wan ZongShun : > >> In order to allow the sharing of the pxa2xx-ac97 driver file with pxa168, > >> we have to do a little change to pxa2xx-ac97 file. > >> > >> All private register addresses were located in mach/include/ac97.h. > > > > This is not the right way to go, as suggested already. I hope the ac97 > > driver is more self-contained. i.e. having a platform device for: > > > > - where the registers are mapped from > > - drcmr channel numbers can be encoded within dma resource > > - ac97 register definitions are not exposed everywhere > > > > Got it, so I should put above to platform_device and remove regs-ac97.h, > any private bit definition should be removed to driver directory as > driver _only_. > ...and could you also CC Mark on any ASoC related changes too. Thanks Liam -- Freelance Developer, SlimLogic Ltd ASoC and Voltage Regulator Maintainer. http://www.slimlogic.co.uk