From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Williamson Subject: Re: [RFC PATCH 7/6] savevm: Create a new continue flag to avoid resending block name Date: Tue, 08 Jun 2010 15:32:46 -0600 Message-ID: <1276032766.3079.18.camel@x201> References: <0100608191447.4451.47795.stgit@localhost.localdomain> <20100608211131.10053.73203.stgit@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: anthony@codemonkey.ws, kvm@vger.kernel.org, quintela@redhat.com, chrisw@redhat.com To: qemu-devel@nongnu.org Return-path: Received: from mx1.redhat.com ([209.132.183.28]:27813 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751507Ab0FHVcu (ORCPT ); Tue, 8 Jun 2010 17:32:50 -0400 In-Reply-To: <20100608211131.10053.73203.stgit@localhost.localdomain> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, 2010-06-08 at 15:11 -0600, Alex Williamson wrote: > Allows us to compress the protocol a bit. ... > @@ -284,6 +290,33 @@ int ram_save_live(Monitor *mon, QEMUFile *f, int stage, void *opaque) > return (stage == 2) && (expected_time <= migrate_max_downtime()); > } > > +static inline void *host_from_stream_offset(QEMUFile *f, > + ram_addr_t offset, > + int flags) This probably shouldn't be inline. When sending, we'll continue from COMPRESS or PAGE. We'd get out of sync on the recv if the compiler created separate static blocks. Compiler folks correct me if this can't happen. Alex From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=37693 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OM6Pj-0007Nk-O3 for qemu-devel@nongnu.org; Tue, 08 Jun 2010 17:32:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OM6Pi-0008O1-9G for qemu-devel@nongnu.org; Tue, 08 Jun 2010 17:32:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:6446) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OM6Pi-0008Nh-12 for qemu-devel@nongnu.org; Tue, 08 Jun 2010 17:32:50 -0400 From: Alex Williamson In-Reply-To: <20100608211131.10053.73203.stgit@localhost.localdomain> References: <0100608191447.4451.47795.stgit@localhost.localdomain> <20100608211131.10053.73203.stgit@localhost.localdomain> Content-Type: text/plain; charset="UTF-8" Date: Tue, 08 Jun 2010 15:32:46 -0600 Message-ID: <1276032766.3079.18.camel@x201> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [RFC PATCH 7/6] savevm: Create a new continue flag to avoid resending block name List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: chrisw@redhat.com, kvm@vger.kernel.org, quintela@redhat.com On Tue, 2010-06-08 at 15:11 -0600, Alex Williamson wrote: > Allows us to compress the protocol a bit. ... > @@ -284,6 +290,33 @@ int ram_save_live(Monitor *mon, QEMUFile *f, int stage, void *opaque) > return (stage == 2) && (expected_time <= migrate_max_downtime()); > } > > +static inline void *host_from_stream_offset(QEMUFile *f, > + ram_addr_t offset, > + int flags) This probably shouldn't be inline. When sending, we'll continue from COMPRESS or PAGE. We'd get out of sync on the recv if the compiler created separate static blocks. Compiler folks correct me if this can't happen. Alex