Re: [PATCH] qt4-embedded: rename qtdemo file

[Phil Blundell <philb@gnu.org>]

On Wed, 2010-06-09 at 15:55 +0200, Marco Cavallini wrote:
> #Append an E to the qtdemo file
> if [${QT_LIBINFIX} == "E"] ; then
> 	    mv ${D}${bindir}/qtdemo ${D}${bindir}/qtdemo${QT_LIBINFIX}
> fi

I think you need some quotes around ${QT_LIBINFIX} in the argument to [,
otherwise you are liable to get an error if the variable is empty.  It
might also make more sense to test something like '-n "${QT_LIBINFIX"',
rather than testing for it being 'E' specifically.  But yes, clearly the
current code is not satisfactory in the case of an empty infix.

p.