All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: torvalds@linux-foundation.org
Cc: dhowells@redhat.com, simo@redhat.com,
	Herbert Xu <herbert@gondor.apana.org.au>,
	Jarkko Sakkinen <jarkko@kernel.org>,
	keyrings@vger.kernel.org, linux-crypto@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [GIT PULL] certs: Make signature verification FIPS compliant
Date: Tue, 21 Jun 2022 16:20:09 +0100	[thread overview]
Message-ID: <1276151.1655824809@warthog.procyon.org.uk> (raw)

Hi Linus,

Can you pull this please?  The signature checking code, as used by module
signing, kexec, etc., is non-FIPS compliant as there is no selftest.  For a
kernel to be FIPS-compliant, signature checking would have to be tested
before being used, and the box would need to panic if it's not available
(probably reasonable as simply disabling signature checking would prevent
you from loading any driver modules).

Deal with this by adding a minimal test.

This is split into two patches: the first moves load_certificate_list() to
the same place as the X.509 code to make it more accessible internally; the
second adds a selftest.

David

Link: https://lore.kernel.org/r/165515741424.1554877.9363755381201121213.stgit@warthog.procyon.org.uk/
---
The following changes since commit b13baccc3850ca8b8cccbf8ed9912dbaa0fdf7f3:

  Linux 5.19-rc2 (2022-06-12 16:11:37 -0700)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git tags/certs-20220621

for you to fetch changes up to 3cde3174eb910513d32a9ec8a9b95ea59be833df:

  certs: Add FIPS selftests (2022-06-21 16:05:12 +0100)

----------------------------------------------------------------
Certs changes

----------------------------------------------------------------
David Howells (2):
      certs: Move load_certificate_list() to be with the asymmetric keys code
      certs: Add FIPS selftests

 certs/Makefile                                     |   4 +-
 certs/blacklist.c                                  |   8 +-
 certs/common.h                                     |   9 -
 certs/system_keyring.c                             |   6 +-
 crypto/asymmetric_keys/Kconfig                     |  10 +
 crypto/asymmetric_keys/Makefile                    |   2 +
 crypto/asymmetric_keys/selftest.c                  | 224 +++++++++++++++++++++
 .../asymmetric_keys/x509_loader.c                  |   8 +-
 crypto/asymmetric_keys/x509_parser.h               |   9 +
 crypto/asymmetric_keys/x509_public_key.c           |   8 +-
 include/keys/asymmetric-type.h                     |   3 +
 11 files changed, 268 insertions(+), 23 deletions(-)
 delete mode 100644 certs/common.h
 create mode 100644 crypto/asymmetric_keys/selftest.c
 rename certs/common.c => crypto/asymmetric_keys/x509_loader.c (87%)


             reply	other threads:[~2022-06-21 15:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-21 15:20 David Howells [this message]
2022-06-21 18:27 ` [GIT PULL] certs: Make signature verification FIPS compliant pr-tracker-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1276151.1655824809@warthog.procyon.org.uk \
    --to=dhowells@redhat.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=jarkko@kernel.org \
    --cc=keyrings@vger.kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=simo@redhat.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.