From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id F2EA7100897 for ; Fri, 11 Jun 2010 11:18:14 +1000 (EST) Subject: Re: [PATCH 5/5] of/irq: merge of_irq_map_one() From: Benjamin Herrenschmidt To: Grant Likely In-Reply-To: References: <20100604212134.10552.70717.stgit@angua> <20100604212155.10552.19260.stgit@angua> <1276152002.1962.55.camel@pasglop> Content-Type: text/plain; charset="UTF-8" Date: Fri, 11 Jun 2010 11:17:52 +1000 Message-ID: <1276219072.1962.82.camel@pasglop> Mime-Version: 1.0 Cc: Stephen Rothwell , Michal Simek , microblaze-uclinux@itee.uq.edu.au, devicetree-discuss@lists.ozlabs.org, linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, 2010-06-10 at 17:36 -0600, Grant Likely wrote: > > Okay. I had been trying to avoid #ifdefs in the common code, but > you're probably right. I'll rework. Not even ifdef's ... just move the quirk map there. You can always #define the quirk variable to 0 on archs that have no quirks, to make it compile away if you believe it represents bloat, but they are simple well localized things so I doubt it matters. Cheers, Ben. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Herrenschmidt Subject: Re: [PATCH 5/5] of/irq: merge of_irq_map_one() Date: Fri, 11 Jun 2010 11:17:52 +1000 Message-ID: <1276219072.1962.82.camel@pasglop> References: <20100604212134.10552.70717.stgit@angua> <20100604212155.10552.19260.stgit@angua> <1276152002.1962.55.camel@pasglop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Grant Likely Cc: Stephen Rothwell , microblaze-uclinux-rVRm/Wmeqae7NGdpmJTKYQ@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org List-Id: devicetree@vger.kernel.org On Thu, 2010-06-10 at 17:36 -0600, Grant Likely wrote: > > Okay. I had been trying to avoid #ifdefs in the common code, but > you're probably right. I'll rework. Not even ifdef's ... just move the quirk map there. You can always #define the quirk variable to 0 on archs that have no quirks, to make it compile away if you believe it represents bloat, but they are simple well localized things so I doubt it matters. Cheers, Ben.