From: Artem Bityutskiy <dedekind1@gmail.com>
To: kyungmin.park@samsung.com
Cc: 'Thomas Gleixner' <tglx@linutronix.de>,
linux-mtd@lists.infradead.org,
'Joonyoung Shim' <jy0922.shim@samsung.com>
Subject: RE: [PATCH 1/2] mtd: OneNAND: Add runtime badblock check feature
Date: Mon, 14 Jun 2010 07:07:00 +0300 [thread overview]
Message-ID: <1276488420.19028.229.camel@localhost> (raw)
In-Reply-To: <012f01cb0b4e$db1a7550$914f5ff0$%park@samsung.com>
On Mon, 2010-06-14 at 08:19 +0900, Kyungmin Park wrote:
> > Also, if you really want this, it should be rather lazy checking, where
> > you read OOB on demand, and then save this information to the in-ram
> > BBT, and when you get another ->block_isbad() for a block which was
> > previously checked, you do not read OOB for the second time.
>
> It's based on BBT already. Now I set the BBT values as 0x2 and then
> check it at runtime and then mark it 0 for good, 3 for bad block.
I meant why you are optimizing the in-ram BBT instead of just keeping
and maintaining the BBT on the flash media?
> Right, it's same word lazy checking and runtime check.
I think you should rename it. "Runtime" is not descriptive, because even
without your patch the BBT is built "runtime". But "lazy" BBT creation
is quite descriptive.
> The original ideas are from UBI scan it read all blocks again at probe.
> I just scan almost block read once at ubi scan.
Right. So I asked why not to just have the BBT on flash?
Also, I doubt we need yet another config option and chip option - why
not to make lazy BBT just to be the default?
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
next prev parent reply other threads:[~2010-06-14 4:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-01 8:17 [PATCH 1/2] mtd: OneNAND: Add runtime badblock check feature Joonyoung Shim
2010-06-01 8:17 ` [PATCH 2/2] mtd: OneNAND: Support runtime badblock check of Samsung Soc OneNAND Joonyoung Shim
2010-06-13 9:26 ` [PATCH 1/2] mtd: OneNAND: Add runtime badblock check feature Artem Bityutskiy
2010-06-13 23:19 ` Kyungmin Park
2010-06-14 4:07 ` Artem Bityutskiy [this message]
2010-06-29 6:38 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1276488420.19028.229.camel@localhost \
--to=dedekind1@gmail.com \
--cc=jy0922.shim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-mtd@lists.infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.