All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Airlie <airlied@gmail.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH] i915: fix ironlake edp panel setup.
Date: Fri, 25 Jun 2010 16:21:40 +1000	[thread overview]
Message-ID: <1277446900-16411-1-git-send-email-airlied@gmail.com> (raw)

From: Dave Airlie <airlied@redhat.com>

We've just gotten an eDP laptop, and kms was booting to a black screen.

as much as I hate Keith's magic * 3, it seems to work a lot better than the non-magic.

aligning the non-magic seems to make things a lot happier, and aligns better with what the bios appears to do, since the bios ends up using thehigher clock in VGA mode.

Signed-off-by: Dave Airlie <airlied@redhat.com>
---
 drivers/gpu/drm/i915/intel_dp.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index 6094e42..80e122d 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -133,7 +133,7 @@ intel_dp_link_required(struct drm_device *dev,
 	struct intel_dp_priv *dp_priv = intel_encoder->dev_priv;
 
 	if (IS_eDP(intel_encoder) || IS_PCH_eDP(dp_priv))
-		return (pixel_clock * dev_priv->edp_bpp) / 8;
+		return (pixel_clock * ALIGN(dev_priv->edp_bpp, 8)) / 8;
 	else
 		return pixel_clock * 3;
 }
-- 
1.7.1

             reply	other threads:[~2010-06-25  6:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-25  6:21 Dave Airlie [this message]
2010-06-25  6:59 ` [PATCH] i915: fix ironlake edp panel setup Keith Packard
2010-06-25 11:16   ` Ben Guthro
2010-06-26  9:56 ` Zhenyu Wang
2010-06-27 23:46   ` Dave Airlie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1277446900-16411-1-git-send-email-airlied@gmail.com \
    --to=airlied@gmail.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.