All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Hansen <dave@linux.vnet.ibm.com>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Greg KH <gregkh@suse.de>, Nathan Fontenot <nfont@austin.ibm.com>,
	Andi Kleen <andi@firstfloor.org>,
	linux-kernel@vger.kernel.org,
	"Eric W. Biederman" <ebiederm@xmission.com>
Subject: Re: [PATCH] memory hotplug disable boot option
Date: Tue, 29 Jun 2010 09:03:04 -0700	[thread overview]
Message-ID: <1277827384.8354.3413.camel@nimitz> (raw)
In-Reply-To: <20100629115232.38BC.A69D9226@jp.fujitsu.com>

On Tue, 2010-06-29 at 11:56 +0900, KOSAKI Motohiro wrote:
> > On Mon, 2010-06-28 at 08:44 -0700, Greg KH wrote:
> > > > The directories being created are the standard directories, one for each of the memory
> > > > sections present at boot.  I think the most used files in each of these directories
> > > > is the state and removable file used to do memory hotplug.
> > > 
> > > And perhaps we shouldn't really be creating so many directories?  Why
> > > not work with the memory hotplug developers to change their interface to
> > > not abuse sysfs in such a manner? 
> > 
> > Heh, it wasn't abuse until we got this much memory.  But, I think this
> > one is pretty much 100% my fault.
> > 
> > Nathan, I think the right fix here is probably to untie sysfs from the
> > sections a bit.  We should be able to have sysfs dirs that represent
> > more than one contiguous SECTION_SIZE area of memory.
> 
> Why do we need abi breakage? Yourself talked about we guess ppc don't
> actually need 16MB section. I think IBM folks have to confirm it.
> If our guessing is correct, the firmware fixing is only necessary.

>From the mouth of the kernel dumbass who coded this up: it's not the
firmware's fault.  We shouldn't punt this to them, and the proper fix
_isn't_ in the firmware, plus they may have other more fundamental
reasons to keep the LMB sizes what they are.

-- Dave


  parent reply	other threads:[~2010-06-29 16:03 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-25  1:06 [PATCH] memory hotplug disable boot option Nathan Fontenot
2010-06-25  2:04 ` KOSAKI Motohiro
2010-06-25  9:19   ` Andi Kleen
2010-06-25 14:51     ` Nathan Fontenot
2010-06-25 14:56       ` Andi Kleen
2010-06-25 15:21         ` Nathan Fontenot
2010-06-25 15:28           ` Andi Kleen
2010-06-25 16:00             ` Nathan Fontenot
2010-06-28  2:20       ` KOSAKI Motohiro
2010-06-28  4:15         ` Eric W. Biederman
2010-06-28 14:16           ` Andi Kleen
2010-06-28 19:43             ` Eric W. Biederman
2010-06-28 15:02         ` Greg KH
2010-06-28 15:37           ` Nathan Fontenot
2010-06-28 15:44             ` Greg KH
2010-06-29  0:04               ` Dave Hansen
2010-06-29  2:56                 ` KOSAKI Motohiro
2010-06-29 15:38                   ` Nathan Fontenot
2010-06-30  0:00                     ` KOSAKI Motohiro
2010-06-29 16:03                   ` Dave Hansen [this message]
2010-06-29 18:04                     ` Greg KH
2010-06-30  0:32                       ` KAMEZAWA Hiroyuki
2010-06-30 15:47                         ` Greg KH
2010-07-01  0:31                           ` KAMEZAWA Hiroyuki
2010-07-01  3:17                             ` Nathan Fontenot
2010-07-01  3:30                               ` KAMEZAWA Hiroyuki
2010-07-01 23:28                                 ` Greg KH
2010-07-01  5:15                             ` KAMEZAWA Hiroyuki
2010-07-01 13:23                             ` Dave Hansen
2010-07-06 15:20                               ` Nathan Fontenot
2010-07-06 15:33                                 ` Dave Hansen
2010-07-06 15:47                                   ` Nathan Fontenot
2010-07-01 23:26                             ` Greg KH
2010-07-02  5:50                               ` KAMEZAWA Hiroyuki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1277827384.8354.3413.camel@nimitz \
    --to=dave@linux.vnet.ibm.com \
    --cc=andi@firstfloor.org \
    --cc=ebiederm@xmission.com \
    --cc=gregkh@suse.de \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nfont@austin.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.