From: Peter Zijlstra <peterz@infradead.org>
To: Suresh Siddha <suresh.b.siddha@intel.com>
Cc: Venkatesh Pallipadi <venki@google.com>,
LKML <linux-kernel@vger.kernel.org>,
Gautham R Shenoy <ego@in.ibm.com>,
Joel Schopp <jschopp@austin.ibm.com>,
Michael Neuling <mikey@neuling.org>
Subject: Re: [PATCH] sched: Call update_group_power only for local_group
Date: Fri, 09 Jul 2010 15:17:47 +0200 [thread overview]
Message-ID: <1278681467.1900.199.camel@laptop> (raw)
In-Reply-To: <1278626014.2834.74.camel@sbs-t61.sc.intel.com>
On Thu, 2010-07-08 at 14:53 -0700, Suresh Siddha wrote:
> Also, looking at all this, don't we need to do something like this in
> the nohz load balance?
Yes, I think you're right, thanks!
> diff --git a/kernel/sched_fair.c b/kernel/sched_fair.c
> index 9910e1b..ae750e9 100644
> --- a/kernel/sched_fair.c
> +++ b/kernel/sched_fair.c
> @@ -3598,6 +3598,7 @@ static void nohz_idle_balance(int this_cpu, enum cpu_idle_type idle)
> }
>
> raw_spin_lock_irq(&this_rq->lock);
> + update_rq_clock(this_rq);
> update_cpu_load(this_rq);
> raw_spin_unlock_irq(&this_rq->lock);
next prev parent reply other threads:[~2010-07-09 13:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-01 23:12 [PATCH] sched: Call update_group_power only for local_group Venkatesh Pallipadi
2010-07-02 8:05 ` Peter Zijlstra
2010-07-02 16:20 ` Venkatesh Pallipadi
2010-07-02 16:40 ` Peter Zijlstra
2010-07-02 16:56 ` Venkatesh Pallipadi
2010-07-02 17:31 ` Peter Zijlstra
2010-07-08 14:12 ` Peter Zijlstra
2010-07-08 17:45 ` Suresh Siddha
2010-07-08 17:49 ` Peter Zijlstra
2010-07-08 17:50 ` Suresh Siddha
2010-07-08 17:55 ` Peter Zijlstra
2010-07-08 18:16 ` Peter Zijlstra
2010-07-08 21:53 ` Suresh Siddha
2010-07-09 13:17 ` Peter Zijlstra [this message]
2010-07-17 11:12 ` [tip:sched/core] sched: Update rq->clock for nohz balanced cpus tip-bot for Suresh Siddha
2010-07-12 17:11 ` [PATCH] sched: Call update_group_power only for local_group Venkatesh Pallipadi
2010-07-17 11:12 ` [tip:sched/core] sched: Reduce update_group_power() calls tip-bot for Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1278681467.1900.199.camel@laptop \
--to=peterz@infradead.org \
--cc=ego@in.ibm.com \
--cc=jschopp@austin.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mikey@neuling.org \
--cc=suresh.b.siddha@intel.com \
--cc=venki@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.