All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nathan Lynch <ntl-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>
To: orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org
Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
Subject: [PATCH 9/8] restore_sigpending: fix reversed list_add_tail arguments
Date: Tue, 13 Jul 2010 17:22:57 -0500	[thread overview]
Message-ID: <1279059777.3002.1282.camel@localhost> (raw)
In-Reply-To: <1279035864-10533-1-git-send-email-ntl-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>

A testcase that posts several realtime signals via sigqueue before C/R
uncovered this.  Without this change only the first queued signal is
delivered after restart.

Signed-off-by: Nathan Lynch <ntl-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>
---

[only noticed this after posting the series, oops]

 kernel/signal.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/signal.c b/kernel/signal.c
index cc7aee9..ba8a623 100644
--- a/kernel/signal.c
+++ b/kernel/signal.c
@@ -3277,7 +3277,7 @@ static int restore_sigpending(struct ckpt_ctx *ctx, struct sigpending *pending)
 		}
 
 		q->flags &= ~SIGQUEUE_PREALLOC;
-		list_add_tail(&pending->list, &q->list);
+		list_add_tail(&q->list, &pending->list);
 	}
 
 	if (ret < 0)
-- 
1.7.1.1

  parent reply	other threads:[~2010-07-13 22:22 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-13 15:44 [PATCH 0/8] checkpoint: improve handling of pending signals Nathan Lynch
     [not found] ` <1279035864-10533-1-git-send-email-ntl-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>
2010-07-13 15:44   ` [PATCH 1/8] checkpoint: model ckpt_siginfo on signalfd_siginfo Nathan Lynch
     [not found]     ` <1279035864-10533-2-git-send-email-ntl-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>
2010-07-16  0:55       ` Sukadev Bhattiprolu
2010-07-13 15:44   ` [PATCH 2/8] checkpoint: add const qualifiers to siginfo handlers Nathan Lynch
     [not found]     ` <1279035864-10533-3-git-send-email-ntl-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>
2010-07-13 23:29       ` Matt Helsley
2010-07-13 15:44   ` [PATCH 3/8] checkpoint: clean up pending posix timer signal handling Nathan Lynch
2010-07-13 15:44   ` [PATCH 4/8] checkpoint: clean up __SI_POLL siginfo save/restore Nathan Lynch
2010-07-13 15:44   ` [PATCH 5/8] checkpoint: clean up __SI_FAULT " Nathan Lynch
2010-07-13 15:44   ` [PATCH 6/8] checkpoint: clean up __SI_CHLD " Nathan Lynch
2010-07-13 15:44   ` [PATCH 7/8] checkpoint: __SI_KILL does not use si_ptr Nathan Lynch
2010-07-13 15:44   ` [PATCH 8/8] checkpoint: handle siginfo->si_code < 0 Nathan Lynch
2010-07-13 22:22   ` Nathan Lynch [this message]
2010-07-13 23:36     ` [PATCH 9/8] restore_sigpending: fix reversed list_add_tail arguments Matt Helsley
2010-07-20  3:00   ` [PATCH 0/8] checkpoint: improve handling of pending signals Oren Laadan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1279059777.3002.1282.camel@localhost \
    --to=ntl-e+axbwqsrlaavxtiumwx3w@public.gmane.org \
    --cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.