All of lore.kernel.org
 help / color / mirror / Atom feed
From: Will Palmer <wmpalmer@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCHv2 1/2] add basic tests for merge-tree
Date: Wed, 14 Jul 2010 08:01:33 +0100	[thread overview]
Message-ID: <1279090893.2789.21.camel@dreddbeard> (raw)
In-Reply-To: <7vaapv0xin.fsf@alter.siamese.dyndns.org>

On Tue, 2010-07-13 at 16:31 -0700, Junio C Hamano wrote:
> Will Palmer <wmpalmer@gmail.com> writes:
> 
> > merge-tree had no test cases, so here we add some very basic tests for
> > it, including some known-breakages.
> >
> > Signed-off-by: Will Palmer <wmpalmer@gmail.com>
> > ---
> >  t/t4300-merge-tree.sh |  277 +++++++++++++++++++++++++++++++++++++++++++++++++
> >  1 files changed, 277 insertions(+), 0 deletions(-)
> >  create mode 100755 t/t4300-merge-tree.sh
> 
> This does not sound like part of "the diff commands", unlike apply/diff/log.
> Perhaps somewhere in t3xxx "other basic commands" series?

I was a bit iffy on this one. Part of this was, admittedly, because
t3[0-9] were all taken, and I'm not sure about what number should be
used after that (perhaps t/README needs to be updated? It only mentions
three digits, but lists the template as tNNNN)

However, merge-tree has a function similar to diff (it shows differences
between trees) and apply (it creates the "result" object when there are
no conflicts), and its purpose seems to be more of a "shower" than a
"do-er" (contrasted with something like git-merge, which actually
creates a commit object, for example), so I thought that diff-commands
would be a good classification.

If you can tell me what number it should be, I'll change it.


-- 
-- Will

  reply	other threads:[~2010-07-14  7:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-11 13:16 [PATCHv2 0/2] merge-tree: fix (merge-base a b) b a Will Palmer
2010-07-11 13:16 ` [PATCHv2 1/2] add basic tests for merge-tree Will Palmer
2010-07-13 23:31   ` Junio C Hamano
2010-07-14  7:01     ` Will Palmer [this message]
2010-07-14 16:26       ` Junio C Hamano
2010-07-11 13:16 ` [PATCHv2 2/2] fix merge-tree where two branches share no changes Will Palmer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1279090893.2789.21.camel@dreddbeard \
    --to=wmpalmer@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.