From: Alex Elder <aelder@sgi.com>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 2/5] xfs: simplify and remove xfs_ireclaim
Date: Thu, 15 Jul 2010 13:07:27 -0500 [thread overview]
Message-ID: <1279217247.2054.32.camel@doink> (raw)
In-Reply-To: <1279154300-2018-3-git-send-email-david@fromorbit.com>
On Thu, 2010-07-15 at 10:38 +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> xfs_ireclaim has to get and put te pag structure because it is only
> called with the inode to reclaim. The one caller of this function
> already has a reference on the pag and a pointer to is, so move the
> radix tree delete to the caller and remove xfs_ireclaim completely.
> This avoids a xfs_perag_get/put on every inode being reclaimed.
>
> The overhead was noticed in a bug report at:
>
> https://bugzilla.kernel.org/show_bug.cgi?id=16348
Looks good.
Reviewed-by: Alex Elder <aelder@sgi.com>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
> ---
> fs/xfs/linux-2.6/xfs_sync.c | 31 ++++++++++++++++++++++++-
> fs/xfs/xfs_iget.c | 53 +------------------------------------------
> fs/xfs/xfs_inode.h | 2 +-
> 3 files changed, 32 insertions(+), 54 deletions(-)
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-07-15 18:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-15 0:38 [PATCH 0/5] xfs: reclaim bug fixes Dave Chinner
2010-07-15 0:38 ` [PATCH 1/5] xfs: track AGs with reclaimable inodes in per-ag radix tree Dave Chinner
2010-07-15 18:01 ` Alex Elder
2010-07-16 5:17 ` Christoph Hellwig
2010-07-19 0:17 ` Dave Chinner
2010-07-19 0:24 ` Dave Chinner
2010-07-15 0:38 ` [PATCH 2/5] xfs: simplify and remove xfs_ireclaim Dave Chinner
2010-07-15 18:07 ` Alex Elder [this message]
2010-07-16 5:16 ` Christoph Hellwig
2010-07-15 0:38 ` [PATCH 3/5] xfs: fix xfs_trans_add_item() lockdep warnings Dave Chinner
2010-07-15 18:09 ` Alex Elder
2010-07-16 5:19 ` Christoph Hellwig
2010-07-19 0:24 ` Dave Chinner
2010-07-15 0:38 ` [PATCH 4/5] xfs: use GFP_NOFS for page cache allocation Dave Chinner
2010-07-15 18:10 ` Alex Elder
2010-07-16 5:21 ` Christoph Hellwig
2010-07-15 0:38 ` [PATCH 5/5] xfs: fix memory reclaim recursion deadlock on locked inode buffer Dave Chinner
2010-07-15 18:42 ` Alex Elder
2010-07-16 5:22 ` Christoph Hellwig
2010-07-16 5:23 ` [PATCH 0/5] xfs: reclaim bug fixes Christoph Hellwig
2010-07-19 0:30 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1279217247.2054.32.camel@doink \
--to=aelder@sgi.com \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.