From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e31.co.us.ibm.com (e31.co.us.ibm.com [32.97.110.149]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "e31.co.us.ibm.com", Issuer "Equifax" (verified OK)) by ozlabs.org (Postfix) with ESMTPS id C8AF1B6F11 for ; Sat, 17 Jul 2010 03:18:26 +1000 (EST) Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by e31.co.us.ibm.com (8.14.4/8.13.1) with ESMTP id o6GH7Fl4015829 for ; Fri, 16 Jul 2010 11:07:15 -0600 Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167]) by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o6GHICRC117558 for ; Fri, 16 Jul 2010 11:18:12 -0600 Received: from d03av01.boulder.ibm.com (loopback [127.0.0.1]) by d03av01.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id o6GHI9Z7003283 for ; Fri, 16 Jul 2010 11:18:11 -0600 Subject: Re: [PATCH 5/5] v2 Enable multiple sections per directory for ppc From: Dave Hansen To: Nathan Fontenot In-Reply-To: <4C3F5668.2060407@austin.ibm.com> References: <4C3F53D1.3090001@austin.ibm.com> <4C3F5668.2060407@austin.ibm.com> Content-Type: text/plain; charset="ANSI_X3.4-1968" Date: Fri, 16 Jul 2010 10:18:08 -0700 Message-ID: <1279300688.9207.224.camel@nimitz> Mime-Version: 1.0 Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, KAMEZAWA Hiroyuki , linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, 2010-07-15 at 13:41 -0500, Nathan Fontenot wrote: > linux-2.6.orig/arch/powerpc/platforms/pseries/hotplug-memory.c 2010-07-15 09:54:06.000000000 -0500 > +++ linux-2.6/arch/powerpc/platforms/pseries/hotplug-memory.c 2010-07-15 09:56:19.000000000 -0500 > @@ -17,6 +17,54 @@ > #include > #include > > +static u32 get_memblock_size(void) > +{ > + struct device_node *np; > + unsigned int memblock_size = 0; > + Please give this sucker some units. get_memblock_size_bytes()? get_memblock_size_in_g0ats()? -- Dave From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754665Ab0GPRS2 (ORCPT ); Fri, 16 Jul 2010 13:18:28 -0400 Received: from e31.co.us.ibm.com ([32.97.110.149]:59065 "EHLO e31.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752209Ab0GPRS1 (ORCPT ); Fri, 16 Jul 2010 13:18:27 -0400 Subject: Re: [PATCH 5/5] v2 Enable multiple sections per directory for ppc From: Dave Hansen To: Nathan Fontenot Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@ozlabs.org, KAMEZAWA Hiroyuki In-Reply-To: <4C3F5668.2060407@austin.ibm.com> References: <4C3F53D1.3090001@austin.ibm.com> <4C3F5668.2060407@austin.ibm.com> Content-Type: text/plain; charset="ANSI_X3.4-1968" Date: Fri, 16 Jul 2010 10:18:08 -0700 Message-ID: <1279300688.9207.224.camel@nimitz> Mime-Version: 1.0 X-Mailer: Evolution 2.28.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2010-07-15 at 13:41 -0500, Nathan Fontenot wrote: > linux-2.6.orig/arch/powerpc/platforms/pseries/hotplug-memory.c 2010-07-15 09:54:06.000000000 -0500 > +++ linux-2.6/arch/powerpc/platforms/pseries/hotplug-memory.c 2010-07-15 09:56:19.000000000 -0500 > @@ -17,6 +17,54 @@ > #include > #include > > +static u32 get_memblock_size(void) > +{ > + struct device_node *np; > + unsigned int memblock_size = 0; > + Please give this sucker some units. get_memblock_size_bytes()? get_memblock_size_in_g0ats()? -- Dave From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail144.messagelabs.com (mail144.messagelabs.com [216.82.254.51]) by kanga.kvack.org (Postfix) with ESMTP id 426636B02A6 for ; Fri, 16 Jul 2010 13:18:15 -0400 (EDT) Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227]) by e33.co.us.ibm.com (8.14.4/8.13.1) with ESMTP id o6GHDdmx027781 for ; Fri, 16 Jul 2010 11:13:39 -0600 Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167]) by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id o6GHICZt119500 for ; Fri, 16 Jul 2010 11:18:12 -0600 Received: from d03av01.boulder.ibm.com (loopback [127.0.0.1]) by d03av01.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id o6GHI9Z5003283 for ; Fri, 16 Jul 2010 11:18:11 -0600 Subject: Re: [PATCH 5/5] v2 Enable multiple sections per directory for ppc From: Dave Hansen In-Reply-To: <4C3F5668.2060407@austin.ibm.com> References: <4C3F53D1.3090001@austin.ibm.com> <4C3F5668.2060407@austin.ibm.com> Content-Type: text/plain; charset="ANSI_X3.4-1968" Date: Fri, 16 Jul 2010 10:18:08 -0700 Message-ID: <1279300688.9207.224.camel@nimitz> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: Nathan Fontenot Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@ozlabs.org, KAMEZAWA Hiroyuki List-ID: On Thu, 2010-07-15 at 13:41 -0500, Nathan Fontenot wrote: > linux-2.6.orig/arch/powerpc/platforms/pseries/hotplug-memory.c 2010-07-15 09:54:06.000000000 -0500 > +++ linux-2.6/arch/powerpc/platforms/pseries/hotplug-memory.c 2010-07-15 09:56:19.000000000 -0500 > @@ -17,6 +17,54 @@ > #include > #include > > +static u32 get_memblock_size(void) > +{ > + struct device_node *np; > + unsigned int memblock_size = 0; > + Please give this sucker some units. get_memblock_size_bytes()? get_memblock_size_in_g0ats()? -- Dave -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org