From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1pQQu0-0001Tr-43 for mharc-grub-devel@gnu.org; Fri, 10 Feb 2023 05:45:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pQQtu-0001Qh-3W for grub-devel@gnu.org; Fri, 10 Feb 2023 05:45:06 -0500 Received: from mout.gmx.net ([212.227.17.20]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pQQtq-0000hT-VY for grub-devel@gnu.org; Fri, 10 Feb 2023 05:45:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1676025888; bh=JCIwuqXoC0Nq0uqcaj0hKCY2oVKCpKS98pRPxRqvEsc=; h=X-UI-Sender-Class:Date:From:To:Subject:Cc:References:In-Reply-To; b=iWWWCXwG1/bmJ6ldfu95jDTNubCM2ITcWFJOVhdC7ZW9d0ZQNAJZyzphl+j/R+i0F AhfiPsEVlCYp0G0j+sbgJOy5RYV4Z6czBJWK+MJErT88PPAqcR/RhAJxiOaQqRsM0g +EFiC0XuCT/F8BnAKxjvmXkVOaNnYlMsxAX5eq+Tfb11VTU+Qv5LvsGEzR7N+TC7HU q40T7ClIJO2byqdMzeED2Xk9992K9fMaNI3iZWFZ7NAexY0C/+ghg2VEfZhQNQfsn8 nQTYsS1nbsbpTXjaFc4Bmw/te2O6rf3wfYqySYjjg94iGMznEebpiOD249b+7bXLb8 SXl0MYYbtM/CQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from scdbackup.webframe.org ([84.179.243.254]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1M72sJ-1pVgsi3WiF-008dz7; Fri, 10 Feb 2023 11:44:47 +0100 Date: Fri, 10 Feb 2023 11:44:57 +0100 From: "Thomas Schmitt" To: grub-devel@gnu.org Subject: Re: [PATCH v2] tests: Add pathological iso9660 filesystem tests Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Cc: daniel.kiper@oracle.com,development@efficientek.com References: <20230209055217.2046005-1-development@efficientek.com> In-Reply-To: <20230209055217.2046005-1-development@efficientek.com> Message-Id: <12794390269717389069@scdbackup.webframe.org> X-Provags-ID: V03:K1:Uqr6TURSdM2T7qvZv68/923zsa9VrG8Hz+WanDZv7s80tPZRUfj Af42UBBApSoGEbwuu2kkwlBMAGGxs1rrDAXfVldZfDL7d7PqwB1lkDWrhWJnS3TLPANpt18 hxaumlRioqpwP+FqT6YAbSSjmhqZsD1VyKTm5bydvpb/HwZDkGoF2juImKTcwqPTmD8lEZz /Bzl/Zb2eK3kmHe2ESv0Q== UI-OutboundReport: notjunk:1;M01:P0:2l7mRtf/naM=;BusRx0FFIQxZlLXJXrERJkWuvI6 xevH4Dzr8XJGgSUWBlqs+840MQvoeqFT2VEmAaUBHyavcVr6ud7vPqCs838iDP77pphm5tlaz zZZb6oiRgVNwYiJoyLNBtUgdmKT6OQC1PgDd/q53MuA2CbqJFp8nc/iHSUCSoAEL7uE2BYpMU MZfrBqh943EHO1oTT/Im/q8e835/ADPCI4xY7s3EgKvYfcfGSdrniDKH3G+ItjQ0PW6RhKSXq L4y0cipIAeEQBQVxyBfrhE9wp2pmle+7xyGYOUHKmMXVWJteMHJNa/H3GenICEzYwe6Xq3ohE B1SbneH7TmzuyHt4L8Jjn134SCUC06Ne48FYc4RKg3Kg41YfHjFa5VZRN3i6hYgtzosx+kvez flUkVvqVuw3BtFweVzmyE7MoatK1MBpvfhW4egVfxugTIvppJsVz4QT34datLEMZAHW28IlJN Ks0AMj2YFkc1lccuBxUejEJUpRfoeGvTlPATv6ju4FzcfJaW/z+RDjHp5xqQsA5pkiidGNU9T HUR8AozunjUTvkjibkueotWZUYbyxwUoTAnmHoN6KaNlDVfEQ3/yA1RH94sYRYEkabQR3qGCm L/uKW6iiuedqIJ7iL7xkc/yTnfeGgk997iNvpAd6DeCLZY8fXQgg1yqJnF68OuxOvghJxpIjB 2v7ndswcVMROFtYuhU8ghIs+HcoPQzfWWYz+QkThIdJJSuA4btlc4K08fEGiMPDPIO6WSsKg3 7cIABZdnocDWLWVFbIMQ+dOEjE0jFIIqBlU/kMTX/DOTevib7CNIC7wrSxhADiLjrhnFiklro UjMRFOeigpw9oh5G80PBhDdSicnVXWrwhOsfmguTGT4fvqpjr35r/OZEjjKcewHVzBaZhYyhc eijnosa0gkQDOhO/m1/ym4tdvzg2aZ7DBNc6xGqQ/mpROnFvl8u5btynsF3godvVnceL/aenH Uh72z44jQ+Y3NzzzUjaYUl2oscc= Received-SPF: pass client-ip=212.227.17.20; envelope-from=scdbackup@gmx.net; helo=mout.gmx.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Feb 2023 10:45:07 -0000 Hi, On Wed, 8 Feb 2023 23:52:17 -0600 Glenn Washburn wrote: > These are not added to grub-fs-tester because they are not generated and > none of the filesystem tests are run on these isos. The test is to run t= he > command "ls /" on the iso, and a failure is determined if the command > times out, has non-zero return value or has any output. > > Signed-off-by: Glenn Washburn > --- > v2: Remove temp directory containing extracted ISOs > --- > tests/iso9660_ce_loop.iso.gz | Bin 0 -> 897 bytes > tests/iso9660_ce_loop2.iso.gz | Bin 0 -> 904 bytes > tests/iso9660_test.in | 12 +++++++++++- > 3 files changed, 11 insertions(+), 1 deletion(-) > create mode 100644 tests/iso9660_ce_loop.iso.gz > create mode 100644 tests/iso9660_ce_loop2.iso.gz > > diff --git a/tests/iso9660_ce_loop.iso.gz b/tests/iso9660_ce_loop.iso.gz > new file mode 100644 > index 0000000000000000000000000000000000000000..9c53c569b8e5c2441273d49f= 4c8e13e4b3303c24 > GIT binary patch > literal 897 > zcmb2|=3D3ofBusfN7`Rxt=3D{M#uq3<N2(O2EDtVk > zV!mF;l$o*IlVjfrJNEhM(>tw&wEQkz$h$g?`Kr;{^NWwz@Be?_yzkL zBMZ*vjOI-%PkDY@P!aue*Zzaq4`m;3TYuF0MM=3D}%&};V&Ru zcYbM}Jd5?~Z?n_>ZnR$cYS&()@00TO-|oL;;k(=3DOmM{C=3DiVM zRp+eIuf%xF7tgP@mEZA=3D`Q1@Zn;v%0TmFwNc1#i6|FFnSBBxq3=3DX&U$oWoNsY > z#_wqSvIkrf>qL%wO1MZ*@eTFc#D4Vlsq24hKSos?-|;s4BcIjWg#4*n%M0S}#LK*6 > zd8sv(ZLaGJmh*?A=3DiX*Ncy8C zc_w=3DNw?7?zT(xV}=3D5vy!;+LKuy&ZR+ecj)N>Ovv@$BvV}UAExUOFfdmV~!x(?Ksxk > zrK0w?3sn8izx&T{;OocR$I{=3DVee?YBJpSODC#ye%Zd);Fuhnh6m|Lc2+~eEk&)ZsW > z`{Zcdjp)!o > zZ z_J6@^rIx?#B>5)i{M*p+O6$Mgs?&?vT|@kyyUw*gv+V89HS3;*#`TJ;_n%t4sB_li > zn`>4*zqn%6;>fF0)Gw}(5fA*lW2X4z6`E=3D{OX8lL&523z6?}TNWZu)yFIMDy$|$R` > z(3{=3Dvx;N*}nXWxDQ!CB%S7%-cIbIr9vUpqjBd4QfC${Yl+-Wg)+hh&($iEg zu2=3Dlj^TiF$Y|9O9; > z{>Z9lzF+YF?B9bQs^+9VK7Z(e&Ca*$l^EU!?x^|p?Y})kjQVNo`YdodlHa_%`u03V > Tj6@S-|DS2eE8$QE1||jom5H3- > > literal 0 > HcmV?d00001 > > diff --git a/tests/iso9660_ce_loop2.iso.gz b/tests/iso9660_ce_loop2.iso.= gz > new file mode 100644 > index 0000000000000000000000000000000000000000..f59e676475cfc8376256ba65= 047451b5ca969e5a > GIT binary patch > literal 904 > zcmb2|=3D3rP?urHZ``Rxt=3D{M#uq3<`+#@LT?l > zg?-)QBTE*}RZ}c{9Q>yELuJ{_9m)%n)Op{A ziNtYF2^VRR(nz1p>_2y(y8f5<9>;sh?Uh^KFSyM4EiAJ7cly!4-wLcf!dIHS*s@UA > zhCja~?;X4K>u z=3DBjg6=3D`r)Y=3DZof7+sf~F#{BN6r%eyL=3DPm!o7CR;g?thx(CXrJunsYt%PtM_`7M6= Se > zGvjwOe%S++4__GcO*ZH-(|EOMMjHR8@~P{8|9;f_VP4_v@ZWq^a})BXZrxrVb|;^I > zdvnQDuVz1KtAn3ExIKSXw_$VM{>*FgyB}{_HA}l#|K+#ce>Hk9Z<)R1ZpnpS_PvRh > z_DlPAH81<~V8yJpuhtYF`?~W> zuq^i2d9#?V$(MiIGZd8m+4NCz_q=3D+cfB)PK?Dq-pJ9kU#=3DIhIE54FY~PWqGj<7MV=3D > z^TQhZMZbkjt$KZ{e(mA!v!4n4+kLQ}``!9gckV|Xox5#8@#`(KKin$(K09USf$93U > z_K53WPu_DY_wc*brGL_UmVGp;5uLLv?egoy4{v@Hs^?t4q*uOo+09Lx3(C@`?%Vuv > z62pOdz4dYJ)!p%jS7|-FuX;FflCIpdz|g*Zy{jI5aFi3>>>AfAm$vy?P2AM(q7c7Z > zliiOd#<_pJSQ8i4oe>juanG9W#~Cp`pH|ex=3Dzq!#d44%(n}*xhnn~%Ua=3DoW+DoN`u > zI=3Do2E_4DFp&p`V#t5Y9W&Fk+fG(08dYT5nj(+a7lcUQbrv=3D84Xx#?wI%$DVw(}a$i > ztd?`{KXvk=3DN&l>uJ+oYOPKCC=3D-q;m6d6wSpw`r5l&z}A9-B$T}u63rnyC&xpUCJp~ > z_x|69FDEC@Z?=3DD|^7ifb{rl`C;(9mde2SEqqq_ZXD9eL-5xx0)|NiG^2tWDh-27Xh > c^m5?%o16ExrDG > literal 0 > HcmV?d00001 > > diff --git a/tests/iso9660_test.in b/tests/iso9660_test.in > index ed0a5bf8d4..0ec28bd066 100644 > --- a/tests/iso9660_test.in > +++ b/tests/iso9660_test.in > @@ -12,4 +12,14 @@ fi > "@builddir@/grub-fs-tester" rockridge_joliet > "@builddir@/grub-fs-tester" joliet_1999 > "@builddir@/grub-fs-tester" rockridge_1999 > -"@builddir@/grub-fs-tester" rockridge_joliet_1999 > \ No newline at end of file > +"@builddir@/grub-fs-tester" rockridge_joliet_1999 > + > +for fs in iso9660_ce_loop iso9660_ce_loop2; do > + tempdir=3D`mktemp -d "${TMPDIR:-/tmp}/${0##*/}.$(date '+%Y%m%d%H%M%S%= N').${fs}.XXX"` || > + { echo "Failed to make temporary directory"; exit 99; } > + gunzip <"$srcdir"/tests/${fs}.iso.gz >"${tempdir}/${fs}.iso" > + output=3D$(LC_ALL=3DC timeout -s KILL "60" \ > + "@builddir@/grub-fstest" "${tempdir}/${fs}.iso" ls / ) || ret=3D$? > + rm -rf "$tempdir" > + test "${ret:-0}" -eq 0 -a -z "$output" > +done > -- > 2.34.1 Tested-by: Thomas Schmitt I tested with the current state of https://git.savannah.gnu.org/git/grub.git by make check with the expected results. With Lidong Chen's patch 5 v3 still in effect: PASS: iso9660_test With the loop breaker of that patch disabled: FAIL: iso9660_test after about 60 seconds. With loop breaker enabled again, but the special handling of CE at the start of a continuation area disabled: FAIL: iso9660_test after some time but less than 60 seconds. (I assume the failure happens because the ls of ce_loop.iso yielded a file name.) No files matching '*.iso' were found remaining in the repo tree afterwards= . =2D-----------------------------------------------------------------------= - But the message in test-suite.log is very sparse: FAIL iso9660_test (exit status: 1) One could come to the impression that one of the logged xorriso runs would be to blame. Those runs emit lots of warnings because of specs violating Volume Id and symbolic links in Joliet. Maybe a message before the loop in tests/iso9660_test.in could help the puzzled user. Like: Testing for proper recognition of CE loops ... Have a nice day :) Thomas