From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: git@vger.kernel.org
Cc: "Junio C Hamano" <gitster@pobox.com>,
"Thomas Rast" <trast@student.ethz.ch>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: [PATCH v2] tests: rename test to work around GNU gettext bug
Date: Mon, 19 Jul 2010 20:28:11 +0000 [thread overview]
Message-ID: <1279571291-5555-1-git-send-email-avarab@gmail.com> (raw)
In-Reply-To: <1279570409-5293-1-git-send-email-avarab@gmail.com>
Rename t0200-gettext.sh to t0200-gettext-basic.sh. Versions of GNU
gettext before v0.15 (released in 2006) fail to run the test because
of an old bug in gettext.sh.
To conform with the FHS gettext.sh prints a help message when it's
invoked directly. To do this it checks if $0 is "gettext.sh". This
check was broken before v0.15, it was checking for *\gettext.sh (to
support Windows), but now correctly checks for *\\gettext.sh.
t0200-gettext.sh matched the former broken check, so on systems with
an old GNU gettext (like RHEL 5.4) the test simply printed:
./t0200-gettext.sh
GNU gettext shell script function library version 0.14.6
Usage: . gettext.sh
FATAL: Unexpected exit with code 1
Which is just the gettext.sh help output:
$ gettext.sh
GNU gettext shell script function library version 0.17
Usage: . gettext.sh
Change the test name to t0200-gettext-basic.sh to work around that.
Reported-by: Thomas Rast <trast@student.ethz.ch>
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
Thomas Rast noted a typo in the commit message offlist. This fixes
that.
t/{t0200-gettext.sh => t0200-gettext-basic.sh} | 0
1 files changed, 0 insertions(+), 0 deletions(-)
rename t/{t0200-gettext.sh => t0200-gettext-basic.sh} (100%)
diff --git a/t/t0200-gettext.sh b/t/t0200-gettext-basic.sh
similarity index 100%
rename from t/t0200-gettext.sh
rename to t/t0200-gettext-basic.sh
--
1.7.2.rc3.125.g94e09.dirty
next prev parent reply other threads:[~2010-07-19 20:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-19 20:13 [PATCH] tests: rename test to work around GNU gettext bug Ævar Arnfjörð Bjarmason
2010-07-19 20:28 ` Ævar Arnfjörð Bjarmason [this message]
2010-07-19 20:38 ` [PATCH v2] " Thomas Rast
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1279571291-5555-1-git-send-email-avarab@gmail.com \
--to=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.