From mboxrd@z Thu Jan 1 00:00:00 1970 From: Liam Girdwood Subject: Re: [PATCH] ASoC: multi-component: SAMSUNG: Fix compile error when registering a DAI Date: Thu, 22 Jul 2010 11:15:52 +0100 Message-ID: <1279793752.3083.40.camel@odin> References: <4C47D3A3.9000102@samsung.com> <4C47F723.4090506@samsung.com> <4C47FBAE.5040106@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ww0-f51.google.com (mail-ww0-f51.google.com [74.125.82.51]) by alsa0.perex.cz (Postfix) with ESMTP id 72DAA10381C for ; Thu, 22 Jul 2010 12:15:56 +0200 (CEST) Received: by wwb22 with SMTP id 22so1658923wwb.20 for ; Thu, 22 Jul 2010 03:15:56 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Seungwhan Youn Cc: Kyungmin Park , Chanwoo Choi , alsa-devel@alsa-project.org, Mark Brown , Joonyoung Shim List-Id: alsa-devel@alsa-project.org On Thu, 2010-07-22 at 17:26 +0900, Seungwhan Youn wrote: > >>>>> + return snd_soc_register_dai(dev, drv); > >>>> How about s3c64xx-i2s? I think, if this patch fixes all errors in > >>> Sorry, I confused your comment. > >>> What do you mean "How about s3c64xx-i2s" ? > >> > >> Actually 'sound/soc/s3c24xx/s3c64xx-i2s.c' has same error. > >> > >> So, If this patch's purpose is to fix compile error, my opinion is > >> that this patch fix all the same errors in 'sound/soc/s3c24xx/'. > > > > The 'sound/soc/s3c24xx/s3c64xx-i2s.c' haven't directly called > > 'snd_soc_register_dai()' function. > > It is call 's3c_i2sv2_register_dai()' in 'sound/soc/s3c24xx/s3c-i2s-v2.c' > > to register a DAI. > > > > Oh, I was confused about this even I modify this few days ago. > I'm sorry that I make you to be confused. > I'm confused too ;) Is this to be applied or not ? Liam -- Freelance Developer, SlimLogic Ltd ASoC and Voltage Regulator Maintainer. http://www.slimlogic.co.uk