From: Patrick Pannuto <ppannuto@codeaurora.org>
To: linux-kernel@vger.kernel.org
Cc: ppannuto@codeaurora.org, Greg Kroah-Hartman <gregkh@suse.de>,
Emese Revfy <re.emese@gmail.com>,
Stephen Hemminger <shemminger@vyatta.com>,
Jens Axboe <jens.axboe@oracle.com>
Subject: [PATCH 1/6] Driver core: Fix potential memory leak
Date: Thu, 22 Jul 2010 15:09:01 -0700 [thread overview]
Message-ID: <1279836546-26913-2-git-send-email-ppannuto@codeaurora.org> (raw)
In-Reply-To: <1279836546-26913-1-git-send-email-ppannuto@codeaurora.org>
In both of the 'goto out' cases, priv has already
been allocated and assigned to bus->p. We reset
bus->p to NULL, but neglect to free bus->p
Signed-off-by: Patrick Pannuto <ppannuto@codeaurora.org>
---
drivers/base/bus.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/base/bus.c b/drivers/base/bus.c
index 12eec3f..eb1b7fa 100644
--- a/drivers/base/bus.c
+++ b/drivers/base/bus.c
@@ -945,8 +945,8 @@ bus_devices_fail:
bus_remove_file(bus, &bus_attr_uevent);
bus_uevent_fail:
kset_unregister(&bus->p->subsys);
- kfree(bus->p);
out:
+ kfree(bus->p);
bus->p = NULL;
return retval;
}
--
1.7.2
next prev parent reply other threads:[~2010-07-22 22:09 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-22 22:09 Possible memory leaks on driver core error paths Patrick Pannuto
2010-07-22 22:09 ` Patrick Pannuto [this message]
2010-07-22 23:39 ` [PATCH 1/6] Driver core: Fix potential memory leak Greg KH
2010-07-22 22:09 ` [PATCH 2/6] Driver core: Fix memory leak on bus_register error path Patrick Pannuto
2010-07-22 23:41 ` Greg KH
2010-07-24 1:19 ` Patrick Pannuto
2010-07-24 1:48 ` Patrick Pannuto
2010-07-27 0:00 ` Greg KH
2010-07-26 23:45 ` Greg KH
2010-07-22 22:09 ` [PATCH 3/6] Driver core: Fix memory leak on class_register " Patrick Pannuto
2010-07-22 23:41 ` Greg KH
2010-07-22 22:09 ` [PATCH 4/6] Driver core: Fix memory leak on sysdev_class_register " Patrick Pannuto
2010-07-22 23:41 ` Greg KH
2010-07-22 22:09 ` [Ocfs2-devel] [PATCH 5/6] ocfs2: Fix memory leak on mlog_sys_init " Patrick Pannuto
2010-07-22 22:09 ` Patrick Pannuto
2010-07-23 17:01 ` [Ocfs2-devel] " Pekka Enberg
2010-07-23 17:01 ` Pekka Enberg
2010-07-22 22:09 ` [PATCH 6/6] kobj: Fix memory leak on error path of kset_create_and_add Patrick Pannuto
2010-07-22 23:43 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1279836546-26913-2-git-send-email-ppannuto@codeaurora.org \
--to=ppannuto@codeaurora.org \
--cc=gregkh@suse.de \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=re.emese@gmail.com \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.