From: Liam Girdwood <lrg@slimlogic.co.uk>
To: matti.j.aaltonen@nokia.com
Cc: alsa-devel@alsa-project.org, broonie@opensource.wolfsonmicro.com,
Ujfalusi Peter <peter.ujfalusi@nokia.com>
Subject: Re: [PATCH v3 0/1] Codec driver for TI WL1273 FM Radio.
Date: Sat, 24 Jul 2010 10:46:17 +0100 [thread overview]
Message-ID: <1279964777.3097.9.camel@odin> (raw)
In-Reply-To: <1279958725.12777.38.camel@masi.mnp.nokia.com>
On Sat, 2010-07-24 at 11:05 +0300, Matti J. Aaltonen wrote:
> Hi.
>
> On Fri, 2010-07-23 at 20:24 +0200, ext Liam Girdwood wrote:
> > On Fri, 2010-07-23 at 15:42 +0300, Matti J. Aaltonen wrote:
> > > Hello all.
> > >
> > > Thank you for comments and thanks to Peter for advice on constraints
> > > and ALSA in general.
> > >
> > > New in this version:
> > >
> > > 1. Now constraints are used in the start-up function. It wasn't as big
> > > a deal as I thought... Also now the codec is always in full duplex
> > > mode. But it still refuses to do the wrong thing with FM as real full
> > > duplex is then impossible.
> > >
> > > 2. Fixed the exported mode support function. The name in now
> > > wl1273_get_format and it returns the audio interface format.
> > >
> > > 3. Removed the remaining obsolete functions.
> > >
> > > 4. Not actually new but...
> > >
> > > >> I didn't do this yet. But could you give me the git URL and then
> > > >> I'll resend?
> > > > git://git.kernel.org/pub/scm/linux/kernel/git/lrg/sound-2.6.git
> > >
> > > I tried the corresponding http URL
> > >
> > > http://www.kernel.org/pub/scm/linux/kernel/git/lrg/sound-2.6.git but
> > > got
> > >
> > > fatal:
> > > http://www.kernel.org/pub/scm/linux/kernel/git/lrg/sound-2.6.git/info/refs
> > > not found: did you run git update-server-info on the server?
> > >
> >
> > Oh, that's the wrong URL. The correct one is :-
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/lrg/asoc-2.6.git
> >
> > Can you re-do against multi-component. The changes all relate to probe()
> > and remove().
>
> Yes. No problem... I actually woke up last night and realized that the
> format function I wrote didn't have a NULL pointer check for the value
> parameter... So please ignore the v2. patch. I'll send version v2.B
> soon...
>
Ok, thanks.
Btw, now that we have a naming convention for components how about this
having a "-radio" or "-fm" device suffix ?
Liam
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
next prev parent reply other threads:[~2010-07-24 9:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-23 12:42 [PATCH v3 0/1] Codec driver for TI WL1273 FM Radio Matti J. Aaltonen
2010-07-23 12:42 ` [PATCH v3 1/1] ASoC: TI WL1273 FM Radio Codec Matti J. Aaltonen
2010-07-23 18:24 ` [PATCH v3 0/1] Codec driver for TI WL1273 FM Radio Liam Girdwood
2010-07-24 8:05 ` Matti J. Aaltonen
2010-07-24 9:46 ` Liam Girdwood [this message]
2010-07-24 10:19 ` Matti J. Aaltonen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1279964777.3097.9.camel@odin \
--to=lrg@slimlogic.co.uk \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=matti.j.aaltonen@nokia.com \
--cc=peter.ujfalusi@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.