Re: [PATCH 2/4] scsi-disk: refresh the cached capacity from the resize callback

["Philippe Mathieu-Daudé" <philmd@oss.qualcomm.com>]

On 12/8/26 14:14, Denis V. Lunev wrote:
> scsi_disk_resize_cb() reports CAPACITY DATA HAS CHANGED but leaves
> SCSIDevice.max_lba alone, and max_lba is what check_lba_range() compares
> every request against. Until the guest reacts to the unit attention and
> issues READ CAPACITY, requests beyond the old size keep being refused with
> LOGICAL BLOCK ADDRESS OUT OF RANGE, and a guest which never re-reads the
> capacity never recovers at all. A guest migrated onto a device whose size
> changed underneath it is exactly such a guest.
> 
> ide_resize_cb() refreshes its cached size along with the IDENTIFY data it
> reports to the guest. Do the same here, so that the notification is what
> tells the guest about the new capacity rather than what unblocks the
> device.
> 
> Factor the computation out of scsi_disk_reset(), which already had it.
> 
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> ---
>   hw/scsi/scsi-disk.c | 16 ++++++++++++----
>   1 file changed, 12 insertions(+), 4 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@oss.qualcomm.com>