Re: [RFC v2] Bluetooth: Provide access to reassembled Rx packets

[Marcel Holtmann <marcel@holtmann.org>]

Hi Suraj,

> >> Provide the HCI transport driver access to reassembled Rx packets before
> >> sending to Host.
> >
> > you still haven't answered my question on why you want this. It makes no
> > sense to me to relay all packets back to the driver. That is just a
> > waste of CPU cycles.
>
> The requirement is simple. The driver need to know the status of certain 
> vendor specific commands by checking the parameters of Command complete 
> events.

then implement something that handles vendor specific commands and
events properly. This proposal is insane and will not get merged.

> We also have a requirements to verify the status of HCI RESET command to 
> update power management feature.

Then implement something that can track the status of HCI reset
properly.

> If you are concerned about CPU cycle, we can limit this only for HCI 
> events and not for ACL/SCO packets.
> 
> Please do let me know if you think there is an alternate way so that the 
> HCI transport driver can access to HCI events.

So first of all, lets make something perfectly clear. All Bluetooth
drivers are _transport_ drivers. They don't need to know what they are
transporting. And in addition you should not look into the packets that
you are sending or receiving. The Bluetooth core does that HCI packet
parsing.

This is how I want it and how this is going to stay. Everything else is
an insane approach and cost every single driver overhead. In addition
the lifetime rules of SKBs become more and more complicated. That is a
pretty bad thing. It will result in excessive memory usage and will
cause problems.

Regards

Marcel