All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@suse.de>
To: Eric Moore <eric.moore@lsi.com>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH] mpt2sas: driver fails to recover from injected PCIe bus errors
Date: Tue, 27 Jul 2010 11:17:47 -0500	[thread overview]
Message-ID: <1280247467.2833.77.camel@mulgrave.site> (raw)
In-Reply-To: <20100708204431.GA1419@lsil.com>

On Thu, 2010-07-08 at 14:44 -0600, Eric Moore wrote:
> fixes surrounding PCIe enhanced error handling:
> 
> (1) We need to reject all request generated internaly inside the driver as well
> as request arriving from the scsi mid layer when PCIe EEH is active. The fix is
> to add a per adapter flag called pci_error_recovery which is checked thru out
> the driver when request are generated.
> 
> (2) We don't need to call the pci_driver->remove directly from the PCIe
> callbacks becuase its already called from the PCIe EEH code. In its place we are
> shutting down the watchdog timer, and flushing back all pending IO.
> 
> (3) We need to save and restore the pci state across PCIe EEH handling.
> 
> Signed-off-by: Eric Moore <eric.moore@lsi.com>
> 
> diff --git a/drivers/scsi/mpt2sas/mpt2sas_base.c b/drivers/scsi/mpt2sas/mpt2sas_base.c
> old mode 100644
> new mode 100755

Will you watch this type of thing, please?  This changes all the file
modes to executable.  Linus particularly watches for this and will go
into a kill frenzy if he sees it.

I've fixed it up this time.

James



      reply	other threads:[~2010-07-27 16:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-08 20:44 [PATCH] mpt2sas: driver fails to recover from injected PCIe bus errors Eric Moore
2010-07-27 16:17 ` James Bottomley [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1280247467.2833.77.camel@mulgrave.site \
    --to=james.bottomley@suse.de \
    --cc=eric.moore@lsi.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.