All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alex Elder <aelder@sgi.com>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [RFC, PATCH 0/2] xfs: Fast zeroing of allocated space
Date: Tue, 27 Jul 2010 15:49:07 -0500	[thread overview]
Message-ID: <1280263747.2002.200.camel@doink> (raw)
In-Reply-To: <1280210129-10925-1-git-send-email-david@fromorbit.com>

On Tue, 2010-07-27 at 15:55 +1000, Dave Chinner wrote:
> These two patches allow conversion of a written range of a file into
> back into unwritten state. The first patch converts page cache
> helper functions to use the correct range primitives as we need to
> be able to toss (invalidate) pages only within the range specified,
> not to to the end of the file as it currently uses.
> 
> The actual conversion also preallocates any holes in the range, so
> it turns the entire range requested into allocated, unwritten
> extents.
> 
> I also have a patch that adds this functionality to fallocate(). I
> haven't tested that at all, but if this is something we want to
> support, I'd suggest that we want fallocate to be able to do it...

Nice feature.  Kind of surprising to me how small the set
of changes it requires is.

I agree with Christoph's comments.  These two patches otherwise
look good to me as well.

Reviewed-by: Alex Elder <aelder@sgi.com>


_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

      parent reply	other threads:[~2010-07-27 20:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-27  5:55 [RFC, PATCH 0/2] xfs: Fast zeroing of allocated space Dave Chinner
2010-07-27  5:55 ` [PATCH 1/2] xfs: use range primitives for xfs page cache operations Dave Chinner
2010-07-27  6:53   ` Christoph Hellwig
2010-07-27 12:05     ` Dave Chinner
2010-07-27  5:55 ` [PATCH 2/2] xfs: Introduce XFS_IOC_ZERO_RANGE Dave Chinner
2010-07-27  7:59   ` Christoph Hellwig
2010-07-27 20:49 ` Alex Elder [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1280263747.2002.200.camel@doink \
    --to=aelder@sgi.com \
    --cc=david@fromorbit.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.