All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Walker <dwalker@codeaurora.org>
To: linux-arm-msm@vger.kernel.org
Cc: Daniel Walker <dwalker@codeaurora.org>
Subject: [PATCH 5/7] drivers: video: msm: fix hang on disable_irq
Date: Tue, 27 Jul 2010 14:04:30 -0700	[thread overview]
Message-ID: <1280264672-19364-5-git-send-email-dwalker@codeaurora.org> (raw)
In-Reply-To: <1280264672-19364-1-git-send-email-dwalker@codeaurora.org>

There's a resource race around disable_irq. Using the nosync
version allows the function to continue and prevents the hang.

Adapted from Arve Hjønnevåg <arve@android.com> changes in the Google tree.

Signed-off-by: Daniel Walker <dwalker@codeaurora.org>
---
 drivers/video/msm/mdp.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/video/msm/mdp.c b/drivers/video/msm/mdp.c
index 3c28db0..2b5bf79 100644
--- a/drivers/video/msm/mdp.c
+++ b/drivers/video/msm/mdp.c
@@ -90,7 +90,7 @@ static int locked_disable_mdp_irq(struct mdp_info *mdp, uint32_t mask)
 	mdp_irq_mask &= ~(mask);
 	/* if no one is waiting on the interrupt, disable it */
 	if (!mdp_irq_mask) {
-		disable_irq(mdp->irq);
+		disable_irq_nosync(mdp->irq);
 		if (clk)
 			clk_disable(clk);
 	}
-- 
1.7.0.4

-- 
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

  parent reply	other threads:[~2010-07-27 21:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-27 21:04 [PATCH 1/7] msm: fb: initial framebuffer support Daniel Walker
2010-07-27 21:04 ` [PATCH 2/7] msm: gpio support for trout Daniel Walker
2010-07-27 21:04 ` [PATCH 3/7] msm: update clk rate to use min/max values Daniel Walker
2010-07-28 16:22   ` Neil Leeder
2010-07-28 16:41     ` Daniel Walker
2010-07-27 21:04 ` [PATCH 4/7] msm: add CLK_MINMAX to pmdh_clk Daniel Walker
2010-07-27 21:04 ` Daniel Walker [this message]
2010-07-27 21:04 ` [PATCH 6/7] drivers: msm: video: add dev_set_name call Daniel Walker
2010-07-27 21:04 ` [PATCH 7/7] driver: video: msm: change mddi clock name to pmdh_clk Daniel Walker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1280264672-19364-5-git-send-email-dwalker@codeaurora.org \
    --to=dwalker@codeaurora.org \
    --cc=linux-arm-msm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.