All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick Pannuto <ppannuto@codeaurora.org>
To: linux-kernel@vger.kernel.org
Cc: ppannuto@codeaurora.org, Andy Whitcroft <apw@canonical.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Joe Perches <joe@perches.com>
Subject: [PATCH 3/4] Checkpatch: prefer usleep_range over usleep
Date: Tue, 27 Jul 2010 15:39:06 -0700	[thread overview]
Message-ID: <1280270347-4409-4-git-send-email-ppannuto@codeaurora.org> (raw)
In-Reply-To: <1280270347-4409-1-git-send-email-ppannuto@codeaurora.org>

In (almost) every case, usleep_range is better than
usleep, as the precise (ish) wakeup - more accurately
the extra interrupt - from usleep is unnecessary.

usleep_range gives a much better chance of coalescing
processor wakeups.

Signed-off-by: Patrick Pannuto <ppannuto@codeaurora.org>
---
 scripts/checkpatch.pl |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index e3625ac..0650ab9 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2578,6 +2578,11 @@ sub process {
 			}
 		}
 
+# prefer usleep_range over usleep
+		if ($line =~ /\busleep\s*\(.+\);/) {
+			WARN("usleep_range is preferred over usleep; see Documentation/timers/delays.txt\n" . $line);
+		}
+
 # warn about #ifdefs in C files
 #		if ($line =~ /^.\s*\#\s*if(|n)def/ && ($realfile =~ /\.c$/)) {
 #			print "#ifdef in C files should be avoided\n";
-- 
1.7.2


  parent reply	other threads:[~2010-07-27 22:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-27 22:39 [PATCH 0/4 -tip] delay documentation and checkpatch additions Patrick Pannuto
2010-07-27 22:39 ` [PATCH 1/4] Documentation: Add timers/delays.txt Patrick Pannuto
2010-07-27 22:39 ` [PATCH 2/4] Checkpatch: prefer usleep_range over udelay Patrick Pannuto
2010-07-28  0:48   ` Joe Perches
2010-07-27 22:39 ` Patrick Pannuto [this message]
2010-07-27 22:39 ` [PATCH 4/4] Checkpatch: warn about unexpectedly long msleep's Patrick Pannuto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1280270347-4409-4-git-send-email-ppannuto@codeaurora.org \
    --to=ppannuto@codeaurora.org \
    --cc=akpm@linux-foundation.org \
    --cc=apw@canonical.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.