All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Munsie <imunsie@au1.ibm.com>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] ftrace: record command lines at more appropriate moment
Date: Thu, 29 Jul 2010 20:30:32 +1000	[thread overview]
Message-ID: <1280399185-sup-1032@au1.ibm.com> (raw)
In-Reply-To: <20100729015832.GC13088@nowhere>

Excerpts from Frederic Weisbecker's message of Thu Jul 29 11:58:34 +1000 2010:
> In fact I don't really understand what is this tp_benchmark function, when and
> where is it called?

The idea was just to replace a single tracepoint with a call to a
separate function (who's sole action was to call the tracepoint) so that
the ftrace function profiler could profile that function and provide
average timing data for the function call + tracepoint, i.e. like:

noinline void tp_benchmark(...)
{
	trace_...
}

Mostly just laziness on my part really.

> But anyway, I'll rather comment the idea on the patch.

Cheers,
-Ian

      reply	other threads:[~2010-07-29 10:30 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-28  2:29 [PATCH 1/2] ftrace: record command lines at more appropriate moment Ian Munsie
2010-07-28  2:29 ` [PATCH 2/2] Revert "tracing: Allow to disable cmdline recording" Ian Munsie
2010-07-28  2:55 ` [PATCH 1/2] ftrace: record command lines at more appropriate moment Li Zefan
2010-07-28 11:44   ` Ian Munsie
2010-07-28 12:16     ` [PATCH v2] " Ian Munsie
2010-07-29  2:50       ` Frederic Weisbecker
2010-07-29 10:26         ` Ian Munsie
2010-07-29  3:01       ` Li Zefan
2010-07-29  3:04         ` Frederic Weisbecker
2010-07-29  1:58     ` [PATCH 1/2] " Frederic Weisbecker
2010-07-29 10:30       ` Ian Munsie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1280399185-sup-1032@au1.ibm.com \
    --to=imunsie@au1.ibm.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.