From: Alex Elder <aelder@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: have getfacl(1) report numeric id's
Date: Mon, 02 Aug 2010 12:47:44 -0500 [thread overview]
Message-ID: <1280771264.2236.61.camel@doink> (raw)
In-Reply-To: <20100801141549.GB10192@infradead.org>
On Sun, 2010-08-01 at 10:15 -0400, Christoph Hellwig wrote:
> On Fri, Jul 30, 2010 at 04:54:23PM -0500, Alex Elder wrote:
> > This patch arranges for calls to getfacl(1) to be given the "-n"
> > flag, which requests that user and group id's be listed numerically
> > rather than using names. The affected test output files are also
> > updated to indicate the effect of the change.
> >
> > This eliminates some spurious output differences I was seeing, due
> > to the presence of NIS in my test environment.
> >
> > Signed-off-by: Alex Elder <aelder@sgi.com>
>
> Looks good,
>
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
>
> I wonder if this usage should be documented somewhere for future tests.
>
Same goes for the use of _cat_passwd and _cat_group.
I'll add something to the "README" file in the "Test
script environment" section and will post that shortly.
-Alex
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2010-08-02 17:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-30 21:54 [PATCH] xfstests: have getfacl(1) report numeric id's Alex Elder
2010-08-01 14:15 ` Christoph Hellwig
2010-08-02 17:47 ` Alex Elder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1280771264.2236.61.camel@doink \
--to=aelder@sgi.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.