All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Robert Richter <robert.richter@amd.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Carl E. Love" <cel@us.ibm.com>,
	Michael Ellerman <michaele@au1.ibm.com>
Subject: Re: Possible Oprofile crash/race when stopping
Date: Tue, 03 Aug 2010 11:39:33 +1000	[thread overview]
Message-ID: <1280799573.1902.81.camel@pasglop> (raw)
In-Reply-To: <20100728122111.GO26154@erda.amd.com>


> Benjamin,
> 
> thanks for reporting this. I was trying to reproduce this with various
> loads and scenarios, but without success so far. Can you give me a
> hint of the load you have (number of processes running, cpu load, do
> you switch off oprofile while many processes are still running)? Are
> you able to regularly trigger it?

Hi, sorry, I missed your reply, Michael just gave me a wake-up call.

I can't tell that much about the workload, I don't have access to it
either, let's say that from my point of view it's a "customer" binary
blob.

I can re-trigger it though.

> > I think the right sequence however requires breaking up end_sync. Ie, we
> > need to do in that order:
> > 
> >   - cancel the workqueues
> >   - unregister the notifier
> >   - process the mortuary
> > 
> > What do you think ?
> 
> This could potentially fix it, I will have to look deeper into the
> code. Try to do this next week.

Thanks. Let me know.

Cheers,
Ben.



  reply	other threads:[~2010-08-03  1:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-22  5:14 Possible Oprofile crash/race when stopping Benjamin Herrenschmidt
2010-07-28 12:21 ` Robert Richter
2010-08-03  1:39   ` Benjamin Herrenschmidt [this message]
2010-08-13 15:39     ` [PATCH] oprofile: fix crash when accessing freed task structs Robert Richter
2010-08-15 22:22       ` Benjamin Herrenschmidt
2010-08-31 10:28         ` Robert Richter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1280799573.1902.81.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=cel@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michaele@au1.ibm.com \
    --cc=robert.richter@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.