From: Dan Williams <dcbw@redhat.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org
Subject: Re: [wt PATCH 0/5] libertas: make association work again
Date: Wed, 04 Aug 2010 14:15:46 -0500 [thread overview]
Message-ID: <1280949346.11056.1.camel@dcbw.foobar.com> (raw)
In-Reply-To: <1280907989.3768.0.camel@jlt3.sipsolutions.net>
On Wed, 2010-08-04 at 09:46 +0200, Johannes Berg wrote:
> On Wed, 2010-08-04 at 00:41 -0500, Dan Williams wrote:
> > On Fri, 2010-07-30 at 08:35 +0200, Johannes Berg wrote:
> > > On Thu, 2010-07-29 at 23:07 -0700, Dan Williams wrote:
> > > > This series makes libertas actually associate with APs after the
> > > > cfg80211 conversion. There was a pretty big TODO where if cfg80211
> > > > didn't pass in the BSSID of the AP to associate with, then libertas
> > > > would fail because the firmware really, really, really wants a BSSID.
> > > > So lets do a scan to find that BSSID. The other notable change is
> > > > a fix to make sure all supported rates are included in the firmware's
> > > > association request, lack of which caused some APs to deny the attempt.
> > >
> > > I'm a bit tempted to say we could use the connect logic in cfg80211 to
> > > provide this? cfg80211 _already_ provides this if the hardware wants
> > > auth()/assoc() rather than connect() calls, so it seems fairly simple to
> > > also (optionally) do it here?
> >
> > Yeah, I thought about that too. Do you want me to work on that now
> > instead of letting this patch through? I can revert the relevant bits
> > of this later if that's acceptable too.
>
> Either way works for me since I don't care about any cruft in
> libertas ;)
John, if you don't mind applying this patch I'll work on generic
scan-before-connect support in cfg80211 in a further patch series.
Dan
next prev parent reply other threads:[~2010-08-04 19:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-30 6:07 [wt PATCH 0/5] libertas: make association work again Dan Williams
2010-07-30 6:11 ` [wt PATCH 1/5] libertas: get the right # of scanned BSSes Dan Williams
2010-07-30 6:12 ` [wt PATCH 2/5] libertas: better scan response debugging Dan Williams
2010-07-30 6:14 ` [wt PATCH 3/5] libertas: better association request debugging Dan Williams
2010-07-30 6:16 ` [wt PATCH 4/5] libertas: fix association with some APs by using extended rates Dan Williams
2010-07-30 6:18 ` [wt PATCH 5/5] libertas: scan before assocation if no BSSID was given Dan Williams
2010-07-30 6:37 ` Johannes Berg
2010-08-04 5:43 ` [wt PATCH 5/5 v2] " Dan Williams
2010-07-30 6:35 ` [wt PATCH 0/5] libertas: make association work again Johannes Berg
2010-07-31 13:54 ` Holger Schurig
2010-08-04 5:41 ` Dan Williams
2010-08-04 7:46 ` Johannes Berg
2010-08-04 19:15 ` Dan Williams [this message]
2010-08-04 19:34 ` John W. Linville
2010-08-05 17:27 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1280949346.11056.1.camel@dcbw.foobar.com \
--to=dcbw@redhat.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.