All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Mat Martineau <mathewm@codeaurora.org>
Cc: linux-bluetooth@vger.kernel.org, gustavo@padovan.org,
	rshaffer@codeaurora.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 9/9] Bluetooth: Use 3-DH5 payload size for default ERTM max PDU size.
Date: Mon, 09 Aug 2010 04:44:06 -0400	[thread overview]
Message-ID: <1281343446.12579.193.camel@localhost.localdomain> (raw)
In-Reply-To: <1281048867-32630-10-git-send-email-mathewm@codeaurora.org>

Hi Mat,

> The previous value of 672 for L2CAP_DEFAULT_MAX_PDU_SIZE is based on
> the default L2CAP MTU.  That default MTU is calculated from the size
> of two DH5 packets, minus ACL and L2CAP b-frame header overhead.
> 
> ERTM is used with newer basebands that typically support larger 3-DH5
> packets, and i-frames and s-frames have more header overhead.  With
> clean RF conditions, basebands will typically attempt to use 1021-byte
> 3-DH5 packets for maximum throughput.  Adjusting for 2 bytes of ACL
> headers plus 10 bytes of worst-case L2CAP headers yields 1009 bytes
> of payload.
> 
> This PDU size imposes less overhead for header bytes and gives the
> baseband the option to choose 3-DH5 packets, but is small enough for
> ERTM traffic to interleave well with other L2CAP or SCO data.
> 672-byte payloads do not allow the most efficient over-the-air
> packet choice, and cannot achieve maximum throughput over BR/EDR.
> 
> Signed-off-by: Mat Martineau <mathewm@codeaurora.org>
> ---
>  include/net/bluetooth/l2cap.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

patch has been applied. Thanks.

Regards

Marcel



  reply	other threads:[~2010-08-09  8:44 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-05 22:54 [PATCH v3 0/9] Bluetooth: L2CAP updates for PSM validation and ERTM Mat Martineau
2010-08-05 22:54 ` [PATCH 1/9] Bluetooth: Only enable for L2CAP FCS for ERTM or streaming Mat Martineau
2010-08-09  2:43   ` Marcel Holtmann
2010-08-09 13:12     ` Gustavo F. Padovan
2010-08-09 16:50       ` Mat Martineau
2010-08-05 22:54 ` [PATCH 2/9] Bluetooth: Change default ERTM retransmit timeout Mat Martineau
2010-08-09  8:37   ` Marcel Holtmann
2010-08-05 22:54 ` [PATCH 3/9] Bluetooth: Validate PSM values in calls to connect() and bind() Mat Martineau
2010-08-09  2:46   ` Marcel Holtmann
2010-08-05 22:54 ` [PATCH 4/9] Bluetooth: Fix endianness issue with L2CAP MPS configuration Mat Martineau
2010-08-09  8:36   ` Marcel Holtmann
2010-08-05 22:54 ` [PATCH 5/9] Bluetooth: Fix incorrect setting of remote_tx_win for L2CAP ERTM Mat Martineau
2010-08-09  8:41   ` Marcel Holtmann
2010-08-05 22:54 ` [PATCH 6/9] Bluetooth: Add common code for stream-oriented recvmsg() Mat Martineau
2010-08-05 22:54 ` [PATCH 7/9] Bluetooth: Use common SOCK_STREAM receive code in RFCOMM Mat Martineau
2010-08-05 22:54 ` [PATCH 8/9] Bluetooth: Use a stream-oriented recvmsg with SOCK_STREAM L2CAP sockets Mat Martineau
2010-08-09  2:50   ` Marcel Holtmann
2010-08-05 22:54 ` [PATCH 9/9] Bluetooth: Use 3-DH5 payload size for default ERTM max PDU size Mat Martineau
2010-08-09  8:44   ` Marcel Holtmann [this message]
  -- strict thread matches above, loose matches on Subject: below --
2010-08-04 22:48 [PATCH v2 0/9] Bluetooth: L2CAP updates for PSM validation and ERTM Mat Martineau
2010-08-04 22:49 ` [PATCH 9/9] Bluetooth: Use 3-DH5 payload size for default ERTM max PDU size Mat Martineau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1281343446.12579.193.camel@localhost.localdomain \
    --to=marcel@holtmann.org \
    --cc=gustavo@padovan.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=mathewm@codeaurora.org \
    --cc=rshaffer@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.