From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bob Peterson Date: Mon, 8 May 2017 16:08:37 -0400 (EDT) Subject: [Cluster-devel] [PATCH 00/10] fs-DLM: Fine-tuning for several function implementations In-Reply-To: <4bd895d7-9448-928d-1e4c-42326ce20607@users.sourceforge.net> References: <4bd895d7-9448-928d-1e4c-42326ce20607@users.sourceforge.net> Message-ID: <1281357904.5439026.1494274117018.JavaMail.zimbra@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit ----- Original Message ----- | From: Markus Elfring | Date: Sat, 6 May 2017 10:15:25 +0200 | | Some update suggestions were taken into account | from static source code analysis. | | Markus Elfring (10): | Replace six seq_puts() calls by seq_putc() | Add spaces for better code readability | Improve a size determination in table_seq_start() | Use kcalloc() in dlm_scan_waiters() | Improve a size determination in dlm_recover_waiters_pre() | Delete an error message for a failed memory allocation in | dlm_recover_waiters_pre() | Use kmalloc_array() in make_member_array() | Use kcalloc() in two functions | Improve a size determination in two functions | Delete an unnecessary variable initialisation in dlm_ls_start() | | fs/dlm/debug_fs.c | 25 ++++++++++++------------- | fs/dlm/lock.c | 8 +++----- | fs/dlm/member.c | 15 ++++++--------- | 3 files changed, 21 insertions(+), 27 deletions(-) | | -- | 2.12.2 | | Hi Markus, I'm not a DLM maintainer, but I've reviewed your patch set and ACK them. They seem to fit the spirit of: https://www.kernel.org/doc/html/v4.10/process/coding-style.html#allocating-memory I've actually got a bunch of similar cleanups myself, but I don't think there's any overlap. Regards, Bob Peterson Red Hat File Systems From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bob Peterson Date: Mon, 08 May 2017 20:08:37 +0000 Subject: Re: [Cluster-devel] [PATCH 00/10] fs-DLM: Fine-tuning for several function implementations Message-Id: <1281357904.5439026.1494274117018.JavaMail.zimbra@redhat.com> List-Id: References: <4bd895d7-9448-928d-1e4c-42326ce20607@users.sourceforge.net> In-Reply-To: <4bd895d7-9448-928d-1e4c-42326ce20607@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: SF Markus Elfring Cc: cluster-devel@redhat.com, Christine Caulfield , David Teigland , kernel-janitors@vger.kernel.org, LKML ----- Original Message ----- | From: Markus Elfring | Date: Sat, 6 May 2017 10:15:25 +0200 | | Some update suggestions were taken into account | from static source code analysis. | | Markus Elfring (10): | Replace six seq_puts() calls by seq_putc() | Add spaces for better code readability | Improve a size determination in table_seq_start() | Use kcalloc() in dlm_scan_waiters() | Improve a size determination in dlm_recover_waiters_pre() | Delete an error message for a failed memory allocation in | dlm_recover_waiters_pre() | Use kmalloc_array() in make_member_array() | Use kcalloc() in two functions | Improve a size determination in two functions | Delete an unnecessary variable initialisation in dlm_ls_start() | | fs/dlm/debug_fs.c | 25 ++++++++++++------------- | fs/dlm/lock.c | 8 +++----- | fs/dlm/member.c | 15 ++++++--------- | 3 files changed, 21 insertions(+), 27 deletions(-) | | -- | 2.12.2 | | Hi Markus, I'm not a DLM maintainer, but I've reviewed your patch set and ACK them. They seem to fit the spirit of: https://www.kernel.org/doc/html/v4.10/process/coding-style.html#allocating-memory I've actually got a bunch of similar cleanups myself, but I don't think there's any overlap. Regards, Bob Peterson Red Hat File Systems From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756843AbdEHUIs (ORCPT ); Mon, 8 May 2017 16:08:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:62529 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754599AbdEHUIq (ORCPT ); Mon, 8 May 2017 16:08:46 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com F14D53D957 Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=rpeterso@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com F14D53D957 Date: Mon, 8 May 2017 16:08:37 -0400 (EDT) From: Bob Peterson To: SF Markus Elfring Cc: cluster-devel@redhat.com, Christine Caulfield , David Teigland , kernel-janitors@vger.kernel.org, LKML Message-ID: <1281357904.5439026.1494274117018.JavaMail.zimbra@redhat.com> In-Reply-To: <4bd895d7-9448-928d-1e4c-42326ce20607@users.sourceforge.net> References: <4bd895d7-9448-928d-1e4c-42326ce20607@users.sourceforge.net> Subject: Re: [Cluster-devel] [PATCH 00/10] fs-DLM: Fine-tuning for several function implementations MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.3.116.131, 10.4.195.1] Thread-Topic: fs-DLM: Fine-tuning for several function implementations Thread-Index: SuIcp3FdTyhDMcdkFHgGENx3yfdYMg== X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Mon, 08 May 2017 20:08:41 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ----- Original Message ----- | From: Markus Elfring | Date: Sat, 6 May 2017 10:15:25 +0200 | | Some update suggestions were taken into account | from static source code analysis. | | Markus Elfring (10): | Replace six seq_puts() calls by seq_putc() | Add spaces for better code readability | Improve a size determination in table_seq_start() | Use kcalloc() in dlm_scan_waiters() | Improve a size determination in dlm_recover_waiters_pre() | Delete an error message for a failed memory allocation in | dlm_recover_waiters_pre() | Use kmalloc_array() in make_member_array() | Use kcalloc() in two functions | Improve a size determination in two functions | Delete an unnecessary variable initialisation in dlm_ls_start() | | fs/dlm/debug_fs.c | 25 ++++++++++++------------- | fs/dlm/lock.c | 8 +++----- | fs/dlm/member.c | 15 ++++++--------- | 3 files changed, 21 insertions(+), 27 deletions(-) | | -- | 2.12.2 | | Hi Markus, I'm not a DLM maintainer, but I've reviewed your patch set and ACK them. They seem to fit the spirit of: https://www.kernel.org/doc/html/v4.10/process/coding-style.html#allocating-memory I've actually got a bunch of similar cleanups myself, but I don't think there's any overlap. Regards, Bob Peterson Red Hat File Systems